Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueueingBasicConsumer is obsolete #4

Open
dennyferra opened this issue Nov 15, 2016 · 6 comments
Open

QueueingBasicConsumer is obsolete #4

dennyferra opened this issue Nov 15, 2016 · 6 comments

Comments

@dennyferra
Copy link
Collaborator

'QueueingBasicConsumer' is obsolete: 'Deprecated. Use EventingBasicConsumer or a different consumer interface implementation instead'

rabbitmq/rabbitmq-tutorials#58

@nithrous
Copy link
Contributor

nithrous commented Feb 5, 2017

Is EventingBasicConsumer better to use in hangfire queue provider?

@dennyferra
Copy link
Collaborator Author

@nithrous Yes, there are a few benefits of using EventingBasicConsumer, basically:

QueingBasicConsumer does not auto-recover and it was a work around for a message dispatcher issue which no longer exists (in Rabbit MQ). Additionally performance can be improved because EventingBasicConsumer doesn't use any queueing mechanism whereas QueueingBasicConsumer uses SharedQueue<T> which is basically .NET Queue with locks.

I should be able to make these changes within the next few weeks. You can also submit a PR if you wish to make the changes before I get to it.

@dennyferra
Copy link
Collaborator Author

Just referencing pull request: #7

@hin-longkid
Copy link

hin-longkid commented Feb 28, 2017

@dennyferra I wonder when will this PR be merge to master?

@dennyferra
Copy link
Collaborator Author

@hin-longkid Merged

@dennyferra dennyferra reopened this Mar 1, 2017
@dennyferra
Copy link
Collaborator Author

Had to revert, see #9 for details.

This week is busy so I will look into the issues in more detail on Friday (March 3) and should have a new version with the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants