Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize homepage #1393

Open
MiniDigger opened this issue Jul 29, 2024 · 5 comments
Open

optimize homepage #1393

MiniDigger opened this issue Jul 29, 2024 · 5 comments
Labels
1. api This issue/pr relates to an issue/change on the api 2. backend This issue/pr relates to an issue/change on the backend

Comments

@MiniDigger
Copy link
Member

MiniDigger commented Jul 29, 2024 •
edited
Loading

  • fix /api/projects
    • remove the joins in ProjectsApiDAO#getProjects, move platform versions and platform names to hp
    • do the same to countProjects (and maybe look what else uses these filters)
  • improve avatar fetching somehow
@MiniDigger MiniDigger added 1. api This issue/pr relates to an issue/change on the api 2. backend This issue/pr relates to an issue/change on the backend labels Jul 29, 2024
@MiniDigger
Copy link
Member Author

for now I can just rewrite the query I think
like we should be able to aggregate all platform -> version pairs in a subquery
avoiding the joins

MiniDigger added a commit that referenced this issue Jul 31, 2024
@MiniDigger
fix: don't ever join projects and home_projects (partly addresses #1393)
c8a137f
@MiniDigger
Copy link
Member Author

projects api should be fixed, still wanna look at avatars

@MiniDigger
Copy link
Member Author

MiniDigger commented Jul 31, 2024 •
edited
Loading

count broke, see failing tests
also control + f for home_projects and see if we can improve more stuff, also check if we need project extra

@MiniDigger
Copy link
Member Author

ill keep project_extra for now (67e2618)

MiniDigger added a commit that referenced this issue Aug 18, 2024
@MiniDigger
feat: replace some instances of manual avatar fetching for projects (#…
bd4ca23 
…1393)
@MiniDigger
Copy link
Member Author

only 11 cases of avatar fetching left
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. api This issue/pr relates to an issue/change on the api 2. backend This issue/pr relates to an issue/change on the backend
Projects
Hangar Roadmap
Status: New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MiniDigger