Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting escape in a drawer saves the drawer, instead of canceling edits. #21

Open
jelleroorda opened this issue Sep 3, 2021 · 1 comment

Comments

@jelleroorda
Copy link

jelleroorda commented Sep 3, 2021

Bug Description

Hitting the escape key to close the drawer will still persist data inside the drawer. Since it works with the vue store, I am not sure if this is just ‘how it works’, or whether it would be possible to implement. I think it's possible since this is similar how editing blueprints works in Statamic (canceling, escape or clicking outside is the same):

Schermopname.2021-09-03.om.14.23.54.mov

How to Reproduce

Edit something and see that it actually updated the values, instead of canceling them.

Extra Detail

Schermopname.2021-09-03.om.14.24.19.mov

Environment

Statamic 3.2.2 Pro
Laravel 8.58.0
PHP 8.0.6
edalzell/blade-directives 3.5
handmadeweb/buildamic dev-main

@michaelr0
Copy link
Collaborator

@sliver37 this was resolved recently wasn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants