-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt_K
-> qr
in Forward_modeling_for_Fe_I_lines_of_Kurucz.ipynb
#487
Comments
Thanks. @chonma0ctopus Can you also check this? |
Working on this issue at |
I apologize for the bug I left behind that has caused you all trouble. After a quick look, I think @code29563 has made the right point. |
@chonma0ctopus I reached Cell 5 by modifying Cell 1-4 (needed some modifications). Can you take over |
Understood. |
@chonma0ctopus Have you identified the cause of the error? |
Sorry for the further delay. I've finally taken the time to manage the issues in the notebook: https://github.com/chonma0ctopus/exojax/tree/kurucz_bug I see similar problems in a few other files (e.g.,
Quick question: Should I go ahead and merge the notebook fixes into your develop branch first? Or wait until I've sorted out the other files too? |
@chonma0ctopus Thanks! Choose one that suits you best! |
Got it! I'll work on the other files first next weekend. |
Thanks for your patience. |
@chonma0ctopus Hello. Do you think I can help this? or if you already finished correcting all of the source file (except for ipynb/rst), make a PR if you prefer. then I can review. |
Thank you for offering your help. I apologize for not being able to dedicate time to this. It would be helpful if you could check "opacity_Fe_test.py" because this test seems to show some error even before my edit. Thank you again for your support and understanding. |
@chonma0ctopus Thanks for the reply. but, I'm a bit confused. Which version of opacity_Fe_test.py should I check? If I should look at the opacity_Fe_test.py you processed, could you create a draft PR or submit a PR? |
Sorry for the confusion. It was not the version I processed this time, it was giving the error before I edited it. I haven't been able to pinpoint at which point in development the cause was. I thought it might be at Issue #488, but it wasn't; at 49b9e32 we already get an AssertionError. Do you happen to know any smart way to track down at what point the difference occurred? Or, do you think there is no need to track it and rather I can just update the assert statement? |
I see. But you said you have already processed |
Ok, I've submitted a PR. Thank you in advance for your review. |
Thanks for the PR. I do not have any error for shirochan:~/exojax/tests/endtoend/metals(kurucz_bug)>python opacity_Fe_test.py
Reading VALD file
/home/kawahara/exojax/src/exojax/spec/atomllapi.py:612: FutureWarning: Calling float on a single element Series is deprecated and will raise a TypeError in the future. Use float(ser.iloc[0]) instead
ionE = float(
[2.07535337e-19 1.25000001e-05 2.85156250e-05]
[2.07535337e-19 1.25000001e-05 4.53125000e-04]
[2.07535337e-19 1.25000001e-05 1.16015625e-04]
[2.07535337e-19 1.25000001e-05 2.19726562e-05]
[2.07535337e-19 1.25000001e-05 5.09375000e-04] |
Sounds great, but also puzzling...
|
something wrong... Did you do |
Yes, I did both. |
Just to be sure, could you also try using only the CPU instead of GPU? @HajimeKawahara |
@chonma0ctopus shirochan:~/exojax/tests/endtoend/metals(kurucz_bug)>python opacity_Fe_test.py
Reading VALD file
/home/kawahara/exojax/src/exojax/spec/atomllapi.py:612: FutureWarning: Calling float on a single element Series is deprecated and will raise a TypeError in the future. Use float(ser.iloc[0]) instead
ionE = float(
[2.07535337e-19 1.25000001e-05 2.85156250e-05]
[2.07535337e-19 1.25000001e-05 4.53125000e-04]
[2.07535337e-19 1.25000001e-05 1.16015625e-04]
[2.07535337e-19 1.25000001e-05 2.19726562e-05]
[2.07535337e-19 1.25000001e-05 5.09375000e-04] |
Anyway I merged #499. But can you continue to identify the issue making another branch? @chonma0ctopus |
Thank you. I understand! |
I think something missing from this notebook is to divide
qt_K
determined in cell 5 byadbK.QTref_284[mask]
before passing toSijT
(or nowline_strength
) in the next cell, as the function requiresqr: partition function ratio qr(T) = Q(T)/Q(Tref)
for that argument. Could you confirm?The text was updated successfully, but these errors were encountered: