Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization issues #25

Open
humdingerb opened this issue Jan 16, 2025 · 4 comments
Open

Localization issues #25

humdingerb opened this issue Jan 16, 2025 · 4 comments

Comments

@humdingerb
Copy link
Member

humdingerb commented Jan 16, 2025

A few things:

  • The First-Launch-Alert for some reason doesn't show the translated text, but English.
  • Preferences: "Tabs" is weirdly named IMO. Maybe "Zones" is better.
  • Preferences: "unnamed" is untranslated.
  • Date and time display should show in the current locale's formatting. No need for a "24 hour clock" setting then.
@nexus6-haiku
Copy link
Member

nexus6-haiku commented Jan 17, 2025

As of the latest commit?

A few things:

  • The First-Launch-Alert for some reason doesn't show the translated text, but English.

I'll double check but this could be caused by the text being too long?
Do we have examples of such a long text being translated correctly in other apps? It does not come to mind anything similar.

  • Preferences: "Tabs" is weirdly named IMO. Maybe "Zones" is better.

I agree but this is baked into the app almost everywhere, including the scripting suite. Changing it would require a significant rework.

  • Preferences: "unnamed" is untranslated.

See the previous comment but this could be easier to fix.

  • Date and time display should show in the current locale's formatting. No need for a "24 hour clock" setting then.

I agree.

I'd like to release Dockbert as it is now and push these items back to the next release 1.2.

It would be easier to have these split into separate issues, though so we can link them to the relevant commits or PRs once fixed and assign the desired target milestone.

@humdingerb
Copy link
Member Author

I'v tested with the latest, 3b0e704.
I apparently messed up somehow, because I've now cleanly build and the text is localized after all! Though weirdly, before only the button text was localized...

So, first and most important issue is "solved" already. :)

There's a "Create sub-issue" button I haven't seen at GitHub before. You know that?
Should I try it out or rather close this issue and open new ones?

@nexus6-haiku
Copy link
Member

nexus6-haiku commented Jan 17, 2025

There's a "Create sub-issue" button I haven't seen at GitHub before. You know that?
Should I try it out or rather close this issue and open new ones?

Never seen that before.
I played with it a bit and created 3 sub-issues so I don't think we need to close this one. Let's see how it works when we handle them in due course.

@humdingerb
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants