Question: How symfony plugin detects Doctrine mapping driver ?

[soltmar]

Hi @Haehnchen ,

Firstly thanks for the awesome plugin. It helps a lot with doctrine.

I'm using doctrine in non-symfony environment and with your plugin I had no auto-complete problems when using annotations mappings.
Since I've converted everything to Attribute mapping, auto-complete stopped working for joins. Suggestions show correctly in 'select()` though.

I assume this is because annotation is default driver in plugin.

Is there any way to tell the plugin which mapping driver I am using ?

Thanks!

[soltmar]

Any ideas ?

[soltmar]

Just add in, I'm working in Laravel with Laravel-doctrine package.
Any help will be greatly appreciated.

Thanks

[Haehnchen]

sry totally missed this request.

fyi: I have have still in mind, that relations inside php attributes changed "somehow or simplified" in Doctrine. Its already on my todo list to check and extract in "the wild" project cases.

• Feel free to provide code snippets on how you used the joins for attributes; would make it easier here.
• by design the logic is not limited to a Symfony project and was done right from the beginning; improvements can also be done if on detection

are you having still any completion at all? e.g. field completion inside select for fields, for this snippet?

---

All mapping drivers iterated per file, so there no detection involved:

fr.adrienbrault.idea.symfony2plugin.doctrine.metadata.util.DoctrineMetadataUtil#MAPPING_DRIVERS

php attribute driver is located here:

idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/metadata/driver/DoctrinePhpAttributeMappingDriver.java

Line 29 in 3598fb0

public class DoctrinePhpAttributeMappingDriver implements DoctrineMappingDriverInterface {

[m29corey]

I think a problem might be if you omit the targetEntity of the attribute when using typed properties.

When using a *ToOne attribute, Doctrine allows you to omit the targetEntity if you type the property itself.

The attribute mapping driver appears to explicitly look only for the targetEntity of the attribute and does not take a look at the property type itself:

idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/metadata/driver/DoctrinePhpAttributeMappingDriver.java

Line 93 in 3598fb0

PhpExpectedFunctionArgument argument = PhpElementsUtil.findAttributeArgumentByName("targetEntity", attribute);

As soon as I added targetEntity to each attribute, autocomplete started populating as expected within queries.

[soltmar]

I've found that autocompletion didn't work when mappings are set to PHP attributes and having targetEntity typed as string, ie:

This doesn't work:
#[ORM\OneToOne(targetEntity: 'App\Entities\Employees')]
#[ORM\OneToOne(targetEntity: '\App\Entities\Employees')]

This works:
#[ORM\OneToOne(targetEntity: \App\Entities\Employees:class)]

[m29corey]

@soltmar
Indeed, it appears that the code then expects that the targetEntity of the attribute is a class constant:

idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/metadata/driver/DoctrinePhpAttributeMappingDriver.java

Lines 93 to 99 in e73cff8

	PhpExpectedFunctionArgument argument = PhpElementsUtil.findAttributeArgumentByName("targetEntity", attribute);
	if (argument instanceof PhpExpectedFunctionClassConstantArgument) {
	String repositoryClassRaw = ((PhpExpectedFunctionClassConstantArgument) argument).getClassFqn();
	if (StringUtils.isNotBlank(repositoryClassRaw)) {
	doctrineModelField.setRelation(repositoryClassRaw);
	}
	}

But this portion is probably written this way because referencing a class by using ::class is the recommended way, rather than a hard-coded string.

[Haehnchen]

@soltmar i just added your case.

[soltmar]

@soltmar Indeed, it appears that the code then expects that the targetEntity of the attribute is a class constant:

idea-php-symfony2-plugin/src/main/java/fr/adrienbrault/idea/symfony2plugin/doctrine/metadata/driver/DoctrinePhpAttributeMappingDriver.java

Lines 93 to 99 in e73cff8

	PhpExpectedFunctionArgument argument = PhpElementsUtil.findAttributeArgumentByName("targetEntity", attribute);
	if (argument instanceof PhpExpectedFunctionClassConstantArgument) {
	String repositoryClassRaw = ((PhpExpectedFunctionClassConstantArgument) argument).getClassFqn();
	if (StringUtils.isNotBlank(repositoryClassRaw)) {
	doctrineModelField.setRelation(repositoryClassRaw);
	}
	}

But this portion is probably written this way because referencing a class by using ::class is the recommended way, rather than a hard-coded string.

Yeah, but this was a "leftover" in my case when converting legacy entities to attribute based mappings.

@Haehnchen, thanks :)