Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clouds to login, guest-login, portal, and application forms #511

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add clouds to login, guest-login, portal, and application forms #511

wants to merge 3 commits into from

Conversation

noahk004
Copy link
Contributor

@noahk004 noahk004 commented Dec 20, 2024 •
edited by waalbert
Loading

Added cloud background to login portal
image

Closes #500

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit efb9dd8

@noahk004 noahk004 linked an issue Dec 20, 2024 that may be closed by this pull request
Portal has no cloud background #500
Open
IanWearsHat
IanWearsHat requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. One minor note on mobile views.

apps/site/src/app/(main)/login/Login.tsx Outdated Show resolved Hide resolved
@noahk004 noahk004 changed the title Add cloud to portal Add clouds to login, guest-login, portal, and application forms Dec 24, 2024
IanWearsHat
IanWearsHat approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and enhancing other pages!

waalbert
waalbert requested changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@waalbert waalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: on smaller screen widths, the clouds force the page to be a certain width even if this width is bigger than the viewport width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waalbert waalbert waalbert requested changes

@IanWearsHat IanWearsHat IanWearsHat approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Portal has no cloud background
3 participants
@noahk004 @IanWearsHat @waalbert