deleteAdmin Api fix issue #952 #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| router.post('/faq', validation(FAQValidationSchema), faq); | ||
| router.get('/getFaq', getfaq); | ||
| router.put('/deleteFaq', deleteFaq); | ||
| router.put('/deleteFaq',authMiddleware, deleteFaq); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| const error = new ErrorHandler(constants.ERRORS.DATABASE, { | ||
| statusCode: 500, | ||
| message: `You don't have the required permissions`, | ||
| errStack: '', | ||
| }); | ||
| return next(error); | ||
| } | ||
| const [err] = await to(Admin.findById(userId)); | ||
| const [err] = await to(faq.findByIdAndDelete(faqId)); |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
|
1.Initially two faqs cards ---getFaq call |
Kajol-Kumari
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: #952
Proposed changes
deleteFaq api expecting adminId fix
Brief description of what is fixed or changed
deleteFaq api expecting adminId fix
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request