Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Integrate Delete Faq with Backend #679 #945

Closed

Conversation

SwayamRana808
Copy link
Contributor

@SwayamRana808 SwayamRana808 commented May 21, 2024

Issue that this pull request solves

[Backend] Integrate Delete Faq with Backend #679
Closes: #679

Proposed changes

Integrated Delete Faq with Backend in Admin manageFAQ

Brief description of what is fixed or changed

Integrated Delete Faq with Backend in Admin manageFAQ

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface
image

Other information

Any other information that is important to this pull request
I have removed LINK from Faq.jsx as Link as generating warning of "to" not defined as and it also makes the accordian freeze after going to manageFaq page. Removing LINK solved that problem

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 21, 2024 16:05
setIsFetching(true);
const url = `${END_POINT}/deleteFaq`;
const body = {
userId: props.adminData._id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete api expecting adminId in body is wrong, @SwayamRana808 can you fixx https://github.com/HITK-TECH-Community/Community-Website/blob/main/backend/app/routes/faq/deleteFaq.js api using #933 as reference, you can create a separate issue for the same. Till then we will keep this pr on hold

Copy link
Contributor Author

@SwayamRana808 SwayamRana808 May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i should remove adminId and add authmiddleware right? issue @Kajol-Kumari

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes correct @SwayamRana808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Integrate Delete Faq with Backend
2 participants