Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Integrate Delete Contact Us API Fixed #934

Merged
merged 2 commits into from
May 20, 2024

Conversation

Hemu21
Copy link
Contributor

@Hemu21 Hemu21 commented May 20, 2024

Issue that this pull request solves

Issue Link resolve #927

Closes: #927

Brief description of what is fixed or changed

the delete button on contact Us card of the admin panel is integrate it with the delete api.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 20, 2024 02:57
@Hemu21
Copy link
Contributor Author

Hemu21 commented May 20, 2024

@Kajol-Kumari when have a free time can you please check it and merge it.

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 20, 2024
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add loader to the page, when delete api call is happening, and once its successful, render the updated cards with toast message. Only loader is missing, please add the same

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 20, 2024

@Kajol-Kumari Updated. can you please check

@Kajol-Kumari Kajol-Kumari merged commit 60fde3a into HITK-TECH-Community:main May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Integrate Delete Contact Us API
2 participants