update functionality for Admin profile #931
Merged
+290
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -33,7 +46,7 @@ | |||
| router.post('/resetpassword/:token', validationMiddleware(resetPasswordSchema), resetPassword); | |||
|
|
|||
| router.put('/password', validationMiddleware(passwordChangeSchema), authMiddleware, changePassword); | |||
| router.put('/:id/:token', validationMiddleware(updateAdminSchema), updateAdmin); | |||
| router.put('/:id/:token', validationMiddleware(updateAdminSchema),upload.single('image') ,updateAdmin); | |||
Check failure
Code scanning / CodeQL
Missing rate limiting High
Kajol-Kumari
requested changes
May 19, 2024
SwayamRana808
force-pushed
the
updateAdmin
branch
from
592d569
to
dcb03a7
Compare
SwayamRana808
force-pushed
the
updateAdmin
branch
from
1431efc
to
aa9d197
Compare
|
@SwayamRana808 let me know when u are done fixing the requested changes as i can see the current state of this pr is not good, a lot of un-necessary changes are there and functionality is still not intact |
SwayamRana808
force-pushed
the
updateAdmin
branch
from
4e96f18
to
b3d4161
Compare
|
i have changed response json but still it showing in network tab
it should have shown something like this -- @Kajol-Kumari can you please have look on this |
Kajol-Kumari
requested changes
May 22, 2024
number should start with 9-6 it was validity check if number is from India its was already defined in backend |
Kajol-Kumari
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: #896
Proposed changes
[Frontend] Introduce Update Admin Functionality
Brief description of what is fixed or changed
Introduce Update Admin Functionality and also backend api updated
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Untitled.video.-.Made.with.Clipchamp.mp4
Other information
Any other information that is important to this pull request