You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a placeholder ticket. This topic deserves more of a discussion. But I have some thoughts around this.
Currently (at the time of writing), our stack traces are spit out to the console as they would be in a regular python app. In terms of the UI, some of them are displayed to users on regular error pages (like 400: Import errors, see #25 for an example) vs others that are using a generic HTTP status code error (pretty much all of our 403s just say "Forbidden").
This means that we can see errors when they are happening viewing the console errors and we are not leaking stack trace stuff to users via the UI. That's good. But it could be improved.
What we should be doing is:
consistent error logging: we should do JSON logs basically (will write that ticket also), with consistent keys and values. As a subset of this, we should have errors with a consistent JSON format so that we can find historical errors if needed rather than our messy stacktraces
consistent UI logging: I think this can pretty lightweight. We should just use our error template and, in situations where recovery is possible (like validation errors when importing NOFOs), enough info that people can understand how to fix the problem. Ticket Better error message for long headings #25 is an example where our error message does not give people what they need to fix the problem themselves.
The text was updated successfully, but these errors were encountered:
pcraig3
added
the
Dev
This is a dev priority ticket, not strictly user-facing.
label
Dec 6, 2024
pcraig3
changed the title
[Dev ticket] Errors and error logging
Errors and error logging
Dec 6, 2024
This is a placeholder ticket. This topic deserves more of a discussion. But I have some thoughts around this.
Currently (at the time of writing), our stack traces are spit out to the console as they would be in a regular python app. In terms of the UI, some of them are displayed to users on regular error pages (like 400: Import errors, see #25 for an example) vs others that are using a generic HTTP status code error (pretty much all of our 403s just say "Forbidden").
This means that we can see errors when they are happening viewing the console errors and we are not leaking stack trace stuff to users via the UI. That's good. But it could be improved.
What we should be doing is:
The text was updated successfully, but these errors were encountered: