Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up filter components #3331

Open
4 tasks
doug-s-nava opened this issue Dec 20, 2024 · 0 comments
Open
4 tasks

Clean up filter components #3331

doug-s-nava opened this issue Dec 20, 2024 · 0 comments

Comments

@doug-s-nava
Copy link
Collaborator

Summary

A few things that would simplify our filter components for future use and expansion:

  • move accordion content and title functions into their own components
  • memoize functionality where possible
  • improve prop naming / reduce prop drilling where possible
  • try to split out filter section into more bite sized pieces
  • add more comprehensive unit testing around dynamic functionality

Acceptance criteria

functionality around search filter accordions is

  • more fully tested
  • easier to understand
  • more modular and flexible for future use
  • more performant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant