Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Implement header sign in modal #2962

Closed
3 tasks
emilycnava opened this issue Nov 20, 2024 · 1 comment
Closed
3 tasks

Task: Implement header sign in modal #2962

emilycnava opened this issue Nov 20, 2024 · 1 comment
Assignees
@acouch

Comments

@emilycnava
Copy link
Contributor

emilycnava commented Nov 20, 2024 •
edited by doug-s-nava
Loading

Summary

When clicking sign in a modal appears with helper text and a button to take the user to the login.gov sign in page, this ticket is to create that component

See designs in figma here https://www.figma.com/design/FGxWtAgToKhehLJCiuy1zL/Simpler.Grants.gov-Project?node-id=795-16668&node-type=canvas&t=6KLvsPIZIV7dnvju-0

Note that the content in this design may not be finalized, confirm with design before working.

Image

Acceptance criteria

  • reusable modal component created
  • sign in button opens modal
  • modal matches designs and includes button that begins sign in process
@mxk0 mxk0 moved this from Icebox to Todo in Simpler.Grants.gov Product Backlog Nov 25, 2024
@mxk0
Copy link
Collaborator

mxk0 commented Dec 10, 2024

Not must-have for the initial implementation; we'll revisit this later.

@acouch acouch self-assigned this Jan 3, 2025
@acouch acouch moved this from Todo to In Progress in Simpler.Grants.gov Product Backlog Jan 3, 2025
This was referenced Jan 7, 2025
Closed
Merged
acouch added a commit that referenced this issue Jan 10, 2025
@acouch
[Issue #2962] Login modal (#3433)
6f82fa2 
## Summary
Fixes #2962

### Time to review: __15 mins__

## Changes proposed

* Adds a modal for the login link
* Moves the env route handler to a redirect


#### Mobile

![image](https://github.com/user-attachments/assets/4d44f545-f1ce-419e-898d-dde3d859f55b)

#### Desktop

![image](https://github.com/user-attachments/assets/a34ead51-57f7-4c9b-a2e4-631f58e085f3)


### TODO

- [x] verify it is accessible
- [x] add tests
- [x] look over again
@acouch acouch mentioned this issue Jan 10, 2025
Merged
@acouch acouch closed this as completed Jan 10, 2025
acouch added a commit that referenced this issue Jan 13, 2025
@acouch
[Issue #2962] modal followup (#3482)
3804ccd
acouch added a commit that referenced this issue Jan 13, 2025
@acouch
[Issue #2962] Login modal (#3433)
b51562a 
## Summary
Fixes #2962

### Time to review: __15 mins__

## Changes proposed

* Adds a modal for the login link
* Moves the env route handler to a redirect


#### Mobile

![image](https://github.com/user-attachments/assets/4d44f545-f1ce-419e-898d-dde3d859f55b)

#### Desktop

![image](https://github.com/user-attachments/assets/a34ead51-57f7-4c9b-a2e4-631f58e085f3)


### TODO

- [x] verify it is accessible
- [x] add tests
- [x] look over again
acouch added a commit that referenced this issue Jan 13, 2025
@acouch
[Issue #2962] modal followup (#3482)
b17f8e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acouch acouch

Labels
None yet
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #2962] Login modal HHS/simpler-grants-gov
3 participants
@acouch @mxk0 @emilycnava