Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next is making too many requests #2770

Closed
1 task done
doug-s-nava opened this issue Nov 7, 2024 · 1 comment · Fixed by #2797 · May be fixed by #2787 or #2790
Closed
1 task done

Next is making too many requests #2770

doug-s-nava opened this issue Nov 7, 2024 · 1 comment · Fixed by #2797 · May be fixed by #2787 or #2790
Assignees

Comments

@doug-s-nava
Copy link
Collaborator

Summary

@chouinar noticed that

  • for each search page load, 4 search requests are being received by the API, and
  • for each opportunity listing page load, 2 opportunity listing requests are being received

The expectation is that only one request is made in each case.

Initial research points to Next's request memoization not working as expected.

Reproducibility

I tried multiple times and saw the bug every time

How to reproduce the bug

  1. visit a search page
  2. tail your docker logs and notice that 4 requests are received
  3. visit an opportunity page
  4. tail your docker logs and notice that 2 requests are received

Browser

None

Code of Conduct

  • I agree to follow this project's Code of Conduct
@doug-s-nava doug-s-nava self-assigned this Nov 7, 2024
doug-s-nava added a commit that referenced this issue Nov 12, 2024
* make one request to search on page level and pass the unresolved Promise down to each child component
@widal001
Copy link
Collaborator

Beep boop: Automatically setting the point and sprint values for this issue in project HHS/13 because they were unset when the issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment