From 446c640a465edfb3cb6d4cbce51e5d8eeaa9aa34 Mon Sep 17 00:00:00 2001 From: bischoffz Date: Fri, 31 May 2024 01:29:56 -0400 Subject: [PATCH 1/2] spellcheck --- .../ms/taskit/core/CoreTranslationError.java | 4 +-- .../ms/taskit/core/TranslationController.java | 8 +++--- .../ms/taskit/core/TranslationEngine.java | 8 +++--- .../aspr/ms/taskit/core/TranslationSpec.java | 6 ++-- .../hhs/aspr/ms/taskit/core/Translator.java | 4 +-- .../hhs/aspr/ms/taskit/core/TranslatorId.java | 2 +- .../taskit/core/AT_TranslationController.java | 6 ++-- .../ms/taskit/core/AT_TranslationEngine.java | 2 +- .../ms/taskit/core/AT_TranslationSpec.java | 2 +- .../aspr/ms/taskit/core/AT_Translator.java | 24 ++++++++-------- .../core/testsupport/TestObjectUtil.java | 28 +++++++++---------- 11 files changed, 47 insertions(+), 47 deletions(-) diff --git a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/CoreTranslationError.java b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/CoreTranslationError.java index 965eb7c..4fd400f 100644 --- a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/CoreTranslationError.java +++ b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/CoreTranslationError.java @@ -19,7 +19,7 @@ public enum CoreTranslationError implements ContractError { NO_TRANSLATION_ENGINES("There are no translation engines added to this controller."), NULL_CLASS_REF("Null Class Ref"), NULL_DEPENDENCY("Null dependency"), - NULL_INIT_CONSUMER("Null Initilizer Consumer"), + NULL_INIT_CONSUMER("Null Initializer Consumer"), NULL_OBJECT_FOR_TRANSLATION("The object to be translated was null"), NULL_PATH("Null Path"), NULL_TRANSLATION_ENGINE("Null Translation Engine"), @@ -34,7 +34,7 @@ public enum CoreTranslationError implements ContractError { "Translators were added to the builder but were not initialized. Make sure to call super.initTranslators() during your custom engine build method"), UNKNOWN_CLASSREF("No object has been read in with the specified classRef"), UNKNOWN_OBJECT("Object is not Translatable by this TranslationSpec"), - UNKNWON_TRANSLATION_ENGINE_TYPE("Translation Engine Type was not set"), + UNKNOWN_TRANSLATION_ENGINE_TYPE("Translation Engine Type was not set"), UNKNOWN_TRANSLATION_SPEC("No translation spec was provided for the given class"), UNSUPPORTED_VERSION("The given version is not supported"); diff --git a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationController.java b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationController.java index 1dc7737..8b5d1df 100644 --- a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationController.java +++ b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationController.java @@ -15,7 +15,7 @@ import gov.hhs.aspr.ms.util.errors.ContractException; /** - * The TranslatorController serves as the master of cerimonies for translating + * The TranslatorController serves as the master of ceremonies for translating * between two types of objects. Additionally, it has the ability to distribute * Input/Output files for reading and writing. */ @@ -137,7 +137,7 @@ public Builder addInputFilePath(Path filePath, Class classRef, TranslationEng } /** - * Adds the given classRef markerInterace mapping. + * Adds the given classRef markerInterface mapping. *

* explicitly used when calling {@link TranslationController#writeOutput} with a * class for which a classRef ScenarioId pair does not exist and/or the need to @@ -404,7 +404,7 @@ void writeOutput(Path path, M object, Optional> superC * Searches the list of read in objects and returns the first Object found of * the given classRef * - * @param the type of the obect to get + * @param the type of the object to get * @throws ContractException *

*/ public abstract Builder addTranslator(Translator translator); @@ -196,7 +196,7 @@ protected final void _addTranslator(Translator translator) { } /** - * Adds the given classRef markerInterace mapping. + * Adds the given classRef markerInterface mapping. *

* explicitly used when calling {@link TranslationController#writeOutput} with a * class for which a classRef ScenarioId pair does not exist and/or the need to @@ -380,7 +380,7 @@ void checkForCyclicGraph(MutableGraph mutableGraph) { private void validateTranslationEngineType() { if (this.data.translationEngineType == TranslationEngineType.UNKNOWN) { - throw new ContractException(CoreTranslationError.UNKNWON_TRANSLATION_ENGINE_TYPE); + throw new ContractException(CoreTranslationError.UNKNOWN_TRANSLATION_ENGINE_TYPE); } } @@ -401,7 +401,7 @@ Map, Class> getChildParentClassMap() { /** * returns the {@link TranslationEngineType} of this TranslationEngine * - * guarenteed to NOT be {@link TranslationEngineType#UNKNOWN} + * guaranteed to NOT be {@link TranslationEngineType#UNKNOWN} */ public TranslationEngineType getTranslationEngineType() { return this.data.translationEngineType; diff --git a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationSpec.java b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationSpec.java index 40c0f46..f84c627 100644 --- a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationSpec.java +++ b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslationSpec.java @@ -37,14 +37,14 @@ public boolean isInitialized() { * Input Class and if so, calls the related method *

*

- * It then checks if the the object class is assinable from either the App or + * It then checks if the the object class is assignable from either the App or * Input Class and if so, calls the related method *

*

* If no match can be found, an exception is thrown *

* - * @param the expected return type after translation/coversion + * @param the expected return type after translation/conversion * @throws ContractException {@linkplain CoreTranslationError#UNKNOWN_OBJECT} if * no match can be found between the passed in object * and the given appClass and InputClass @@ -102,7 +102,7 @@ public boolean equals(Object obj) { return false; } - // if different intput class, not equal + // if different input class, not equal if (getInputObjectClass() != other.getInputObjectClass()) { return false; } diff --git a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/Translator.java b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/Translator.java index 868d5f7..656925e 100644 --- a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/Translator.java +++ b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/Translator.java @@ -120,9 +120,9 @@ public Builder setInitializer(Consumer initConsumer) { * @throws ContractException *
    *
  • {@linkplain CoreTranslationError#NULL_DEPENDENCY} - * if the dependecy is null
    • + * if the dependency is null *
  • {@linkplain CoreTranslationError#DUPLICATE_DEPENDENCY} - * if the dependecy has already been added
    • + * if the dependency has already been added *
*/ public Builder addDependency(TranslatorId dependency) { diff --git a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslatorId.java b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslatorId.java index 8e0fc97..74a5538 100644 --- a/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslatorId.java +++ b/core/src/main/java/gov/hhs/aspr/ms/taskit/core/TranslatorId.java @@ -5,7 +5,7 @@ */ public interface TranslatorId { /** - * Implementationn consistent with equals() + * Implementation consistent with equals() */ @Override public int hashCode(); diff --git a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationController.java b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationController.java index dddef96..0b8ea46 100644 --- a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationController.java +++ b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationController.java @@ -100,7 +100,7 @@ public void testValidateTranslationEngine() { @Test @UnitTestForCoverage /* - * purpose of this test is to show that if there isnt a valid TranslationEngine + * purpose of this test is to show that if there isn't a valid TranslationEngine * class -> Translation Engine Type -> Translation Engine mapping, an exception * is thrown */ @@ -196,7 +196,7 @@ public void testReadInput() { @Test @UnitTestForCoverage public void testWriteOutput_Engine() { - String fileName = "badFilePath-testoutput.json"; + String fileName = "badFilePath-testOutput.json"; ResourceHelper.createFile(filePath, fileName); TestTranslationEngine engine = TestTranslationEngine.builder() @@ -565,7 +565,7 @@ public void testAddParentChildClassRelationship() { @Test @UnitTestMethod(target = TranslationController.Builder.class, name = "addTranslationEngine", args = { TranslationEngine.class }) - public void testAddTransationEngine() { + public void testAddTranslationEngine() { TestTranslationEngine translationEngine = TestTranslationEngine.builder() .addTranslator(TestObjectTranslator.getTranslator()) .addTranslator(TestComplexObjectTranslator.getTranslator()) diff --git a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationEngine.java b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationEngine.java index f29b08d..f7a48e1 100644 --- a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationEngine.java +++ b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationEngine.java @@ -63,7 +63,7 @@ public void testValidateTranslationEngineType() { engine.validateInit(); }); - assertEquals(CoreTranslationError.UNKNWON_TRANSLATION_ENGINE_TYPE, contractException.getErrorType()); + assertEquals(CoreTranslationError.UNKNOWN_TRANSLATION_ENGINE_TYPE, contractException.getErrorType()); } @Test diff --git a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationSpec.java b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationSpec.java index 3c55fad..d208c68 100644 --- a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationSpec.java +++ b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_TranslationSpec.java @@ -111,7 +111,7 @@ public void testConvert() { assertEquals(expectedAppChildObject, TestObjectUtil.getChildAppFromApp(actualAppChildObject)); // precondition - // TranslationSpec not intialized + // TranslationSpec not initialized ContractException contractException = assertThrows(ContractException.class, () -> { TestObjectTranslationSpec testObjectTranslationSpec2 = new TestObjectTranslationSpec(); testObjectTranslationSpec2.convert(new TestAppObject()); diff --git a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_Translator.java b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_Translator.java index aacb59f..ad0ca24 100644 --- a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_Translator.java +++ b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/AT_Translator.java @@ -21,7 +21,7 @@ public class AT_Translator { @Test @UnitTestMethod(target = Translator.class, name = "getInitializer", args = {}) public void testGetInitializer() { - Consumer expectedInitializer = (translatorConext) -> { + Consumer expectedInitializer = (translatorContext) -> { }; Translator testTranslator = Translator.builder().setInitializer(expectedInitializer) .setTranslatorId(new TranslatorId() { @@ -35,7 +35,7 @@ public void testGetInitializer() { public void testGetTranslatorId() { TranslatorId expectedTranslatorId = new TranslatorId() { }; - Translator testTranslator = Translator.builder().setInitializer((translatorConext) -> { + Translator testTranslator = Translator.builder().setInitializer((translatorContext) -> { }).setTranslatorId(expectedTranslatorId).build(); assertEquals(expectedTranslatorId, testTranslator.getTranslatorId()); @@ -46,7 +46,7 @@ public void testGetTranslatorId() { public void testGetTranslatorDependencies() { TranslatorId expectedTranslatorId = new TranslatorId() { }; - Translator testTranslator = Translator.builder().setInitializer((translatorConext) -> { + Translator testTranslator = Translator.builder().setInitializer((translatorContext) -> { }).setTranslatorId(expectedTranslatorId).addDependency(TestObjectTranslatorId.TRANSLATOR_ID) .addDependency(TestComplexObjectTranslatorId.TRANSLATOR_ID).build(); @@ -66,7 +66,7 @@ public void testHashCode() { }; TranslatorId translatorIdB = new TranslatorId() { }; - Consumer consumerA = (translatorConext) -> { + Consumer consumerA = (translatorContext) -> { }; Translator translatorA = Translator.builder().setInitializer(consumerA).setTranslatorId(translatorIdA).build(); @@ -91,7 +91,7 @@ public void testHashCode() { // if same id, but different dependencies, not equal assertNotEquals(translatorA.hashCode(), translatorC.hashCode()); - // if same id and dependecies, equal + // if same id and dependencies, equal assertEquals(translatorC.hashCode(), translatorD.hashCode()); } @@ -102,7 +102,7 @@ public void testEquals() { }; TranslatorId translatorIdB = new TranslatorId() { }; - Consumer consumerA = (translatorConext) -> { + Consumer consumerA = (translatorContext) -> { }; Translator translatorA = Translator.builder().setInitializer(consumerA).setTranslatorId(translatorIdA).build(); @@ -129,7 +129,7 @@ public void testEquals() { // if same id, but different dependencies, not equal assertNotEquals(translatorA, translatorC); - // if same id and dependecies, equal + // if same id and dependencies, equal assertEquals(translatorC, translatorD); Translator.Data data = new Translator.Data(); @@ -149,7 +149,7 @@ public void testBuilder() { public void testBuild() { TranslatorId translatorIdA = new TranslatorId() { }; - Translator translatorA = Translator.builder().setInitializer((translatorConext) -> { + Translator translatorA = Translator.builder().setInitializer((translatorContext) -> { }).setTranslatorId(translatorIdA).build(); assertNotNull(translatorA); @@ -164,7 +164,7 @@ public void testBuild() { // null translatorId contractException = assertThrows(ContractException.class, () -> { - Translator.builder().setInitializer((translatorConext) -> { + Translator.builder().setInitializer((translatorContext) -> { }).build(); }); @@ -176,7 +176,7 @@ public void testBuild() { public void testSetTranslatorId() { TranslatorId translatorIdA = new TranslatorId() { }; - Translator translatorA = Translator.builder().setInitializer((translatorConext) -> { + Translator translatorA = Translator.builder().setInitializer((translatorContext) -> { }).setTranslatorId(translatorIdA).build(); assertEquals(translatorIdA, translatorA.getTranslatorId()); @@ -193,7 +193,7 @@ public void testSetTranslatorId() { @Test @UnitTestMethod(target = Translator.Builder.class, name = "setInitializer", args = { Consumer.class }) public void testSetInitializer() { - Consumer expectedInitializer = (translatorConext) -> { + Consumer expectedInitializer = (translatorContext) -> { }; Translator testTranslator = Translator.builder().setInitializer(expectedInitializer) .setTranslatorId(new TranslatorId() { @@ -215,7 +215,7 @@ public void testSetInitializer() { public void testAddDependency() { TranslatorId expectedTranslatorId = new TranslatorId() { }; - Translator testTranslator = Translator.builder().setInitializer((translatorConext) -> { + Translator testTranslator = Translator.builder().setInitializer((translatorContext) -> { }).setTranslatorId(expectedTranslatorId).addDependency(TestObjectTranslatorId.TRANSLATOR_ID) .addDependency(TestComplexObjectTranslatorId.TRANSLATOR_ID).build(); diff --git a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/testsupport/TestObjectUtil.java b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/testsupport/TestObjectUtil.java index 2093c9a..9a66c93 100644 --- a/core/src/test/java/gov/hhs/aspr/ms/taskit/core/testsupport/TestObjectUtil.java +++ b/core/src/test/java/gov/hhs/aspr/ms/taskit/core/testsupport/TestObjectUtil.java @@ -81,9 +81,9 @@ public static List getListOfInputObjects(int num) { public static TestAppObject getAppFromInput(TestInputObject inputObject) { TestAppObject appObject = new TestAppObject(); - TestComplexAppObject complextAppObject = getComplexAppFromComplexInput(inputObject.getTestComplexInputObject()); + TestComplexAppObject complexAppObject = getComplexAppFromComplexInput(inputObject.getTestComplexInputObject()); - appObject.setTestComplexAppObject(complextAppObject); + appObject.setTestComplexAppObject(complexAppObject); appObject.setBool(inputObject.isBool()); appObject.setInteger(inputObject.getInteger()); appObject.setString(inputObject.getString()); @@ -93,9 +93,9 @@ public static TestAppObject getAppFromInput(TestInputObject inputObject) { public static TestInputObject getInputFromApp(TestAppObject appObject) { TestInputObject inputObject = new TestInputObject(); - TestComplexInputObject complextInputObject = getComplexInputFromComplexApp(appObject.getTestComplexAppObject()); + TestComplexInputObject complexInputObject = getComplexInputFromComplexApp(appObject.getTestComplexAppObject()); - inputObject.setTestComplexInputObject(complextInputObject); + inputObject.setTestComplexInputObject(complexInputObject); inputObject.setBool(appObject.isBool()); inputObject.setInteger(appObject.getInteger()); inputObject.setString(appObject.getString()); @@ -126,22 +126,22 @@ public static TestInputChildObject getChildInputFromInput(TestInputObject inputO } public static TestComplexAppObject getComplexAppFromComplexInput(TestComplexInputObject inputObject) { - TestComplexAppObject complextAppObject = new TestComplexAppObject(); + TestComplexAppObject complexAppObject = new TestComplexAppObject(); - complextAppObject.setNumEntities(inputObject.getNumEntities()); - complextAppObject.setStartTime(inputObject.getStartTime()); - complextAppObject.setTestString(inputObject.getTestString()); + complexAppObject.setNumEntities(inputObject.getNumEntities()); + complexAppObject.setStartTime(inputObject.getStartTime()); + complexAppObject.setTestString(inputObject.getTestString()); - return complextAppObject; + return complexAppObject; } public static TestComplexInputObject getComplexInputFromComplexApp(TestComplexAppObject appObject) { - TestComplexInputObject complextInputObject = new TestComplexInputObject(); + TestComplexInputObject complexInputObject = new TestComplexInputObject(); - complextInputObject.setNumEntities(appObject.getNumEntities()); - complextInputObject.setStartTime(appObject.getStartTime()); - complextInputObject.setTestString(appObject.getTestString()); + complexInputObject.setNumEntities(appObject.getNumEntities()); + complexInputObject.setStartTime(appObject.getStartTime()); + complexInputObject.setTestString(appObject.getTestString()); - return complextInputObject; + return complexInputObject; } } From 605ef51233332e4d19751a629be1d94e6a9c4822 Mon Sep 17 00:00:00 2001 From: bischoffz Date: Fri, 31 May 2024 01:30:04 -0400 Subject: [PATCH 2/2] spellcheck --- .../protobuf/PrimitiveTranslationSpecs.java | 20 ++++++++--------- .../protobuf/ProtobufTranslationEngine.java | 12 +++++----- .../AT_ProtobufTranslationEngine.java | 10 ++++----- .../protobuf/testsupport/TestObjectUtil.java | 22 +++++++++---------- ...ments.java => BadMessageBadArguments.java} | 4 ++-- .../AT_AnyTranslationSpec.java | 12 +++++----- 6 files changed, 40 insertions(+), 40 deletions(-) rename protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/{BadMessageBadArguements.java => BadMessageBadArguments.java} (72%) diff --git a/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/PrimitiveTranslationSpecs.java b/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/PrimitiveTranslationSpecs.java index 9717848..8eecc04 100644 --- a/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/PrimitiveTranslationSpecs.java +++ b/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/PrimitiveTranslationSpecs.java @@ -54,8 +54,8 @@ class PrimitiveTranslationSpecs { * Returns a set of Protobuf Message {@link Descriptor}s for each of the * Primitive TranslationSpecs. A Descriptor is to a Protobuf Message as Class is * to a Java Object. - *
  • Note: as metioned in the Class javadoc, these Primitive TranslationSpecs - * and their Descriptors are exclusively used to falicitate converting to/from a + *
  • Note: as mentioned in the Class javadoc, these Primitive TranslationSpecs + * and their Descriptors are exclusively used to facilitate converting to/from a * Protobuf {@link Any} type */ Set getPrimitiveDescriptors() { @@ -78,8 +78,8 @@ Set getPrimitiveDescriptors() { /** * Returns a set of {@link ProtobufTranslationSpec}s that includes each of the * Primitive TranslationSpecs. - *
  • Note: as metioned in the Class javadoc, these Primitive TranslationSpecs - * are exclusively used to falicitate converting to/from a Protobuf {@link Any} + *
  • Note: as mentioned in the Class javadoc, these Primitive TranslationSpecs + * are exclusively used to facilitate converting to/from a Protobuf {@link Any} * type */ Set> getPrimitiveTranslatorSpecs() { @@ -94,8 +94,8 @@ Set getPrimitiveDescriptors() { /** * Returns a map of typeUrl to Class that includes each of the Primitive * TranslationSpecs. - *
  • Note: as metioned in the Class javadoc, these Primitive TranslationSpecs - * and their typeUrls are exclusively used to falicitate converting to/from a + *
  • Note: as mentioned in the Class javadoc, these Primitive TranslationSpecs + * and their typeUrls are exclusively used to facilitate converting to/from a * Protobuf {@link Any} type */ Map> getPrimitiveTypeUrlToClassMap() { @@ -129,8 +129,8 @@ Map> getPrimitiveTypeUrlToClassMap() { * Returns a map of {@link Class} to {@link ProtobufTranslationSpec} that * includes each of the Primitive TranslationSpecs. This map is exclusively a * map of the inputObjectClass to the TranslationSpec. - *
  • Note: as metioned in the Class javadoc, these Primitive TranslationSpecs - * and their inputObjectClasses are exclusively used to falicitate converting + *
  • Note: as mentioned in the Class javadoc, these Primitive TranslationSpecs + * and their inputObjectClasses are exclusively used to facilitate converting * to/from a Protobuf {@link Any} type */ Map, ProtobufTranslationSpec> getPrimitiveInputTranslatorSpecMap() { @@ -155,8 +155,8 @@ Map> getPrimitiveTypeUrlToClassMap() { * Returns a map of {@link Class} to {@link ProtobufTranslationSpec} that * includes each of the Primitive TranslationSpecs. This map is exclusively a * map of the appObjectClass to the TranslationSpec. - *
  • Note: as metioned in the Class javadoc, these Primitive TranslationSpecs - * and their appObjectClasses are exclusively used to falicitate converting + *
  • Note: as mentioned in the Class javadoc, these Primitive TranslationSpecs + * and their appObjectClasses are exclusively used to facilitate converting * to/from a Protobuf {@link Any} type */ Map, ProtobufTranslationSpec> getPrimitiveObjectTranslatorSpecMap() { diff --git a/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/ProtobufTranslationEngine.java b/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/ProtobufTranslationEngine.java index a1a3318..b71fa5d 100644 --- a/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/ProtobufTranslationEngine.java +++ b/protobuf/src/main/java/gov/hhs/aspr/ms/taskit/protobuf/ProtobufTranslationEngine.java @@ -159,7 +159,7 @@ public Builder addFieldToIncludeDefaultValue(FieldDescriptor fieldDescriptor) { } /** - * Overriden implementation of + * Override implementation of * {@link TranslationEngine.Builder#addTranslationSpec(TranslationSpec)} that * also populates the type urls for all Protobuf Message types that exist within * the translationSpec @@ -167,7 +167,7 @@ public Builder addFieldToIncludeDefaultValue(FieldDescriptor fieldDescriptor) { * @throws ContractException *
      *
    • {@link ProtobufCoreTranslationError#INVALID_INPUT_CLASS} - * if the given inputClassRef is not assingable from + * if the given inputClassRef is not assignable from * {@linkplain Message} nor * {@linkplain ProtocolMessageEnum}
      • *
    • {@link ProtobufCoreTranslationError#INVALID_TRANSLATION_SPEC} @@ -208,7 +208,7 @@ public Builder addParentChildClassRelationship(Class classRe * descriptorMap and typeUrlToClassMap * * @throws ContractException {@link ProtobufCoreTranslationError#INVALID_INPUT_CLASS} - * if the given inputClassRef is not assingable from + * if the given inputClassRef is not assignable from * {@linkplain Message} nor * {@linkplain ProtocolMessageEnum} */ @@ -363,7 +363,7 @@ private void printJsonToConsole(String jsonString) { *
      • *
    * @throws ContractException {@linkplain ProtobufCoreTranslationError#INVALID_READ_INPUT_CLASS_REF} - * if the given inputClassRef is not assingable + * if the given inputClassRef is not assignable * from * {@linkplain Message} */ @@ -438,7 +438,7 @@ Message.Builder getBuilderForMessage(Class messageClass) { } throw new RuntimeException( - "\"newBuilder\" method exists, but it requires arugments, when it is expected to require 0 arugments"); + "\"newBuilder\" method exists, but it requires arguments, when it is expected to require 0 arguments"); } /** @@ -500,7 +500,7 @@ public Class getClassFromTypeUrl(String typeUrl) { } throw new ContractException(ProtobufCoreTranslationError.UNKNOWN_TYPE_URL, - "Unable to find corrsponding class for: " + typeUrl); + "Unable to find corresponding class for: " + typeUrl); } } diff --git a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/AT_ProtobufTranslationEngine.java b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/AT_ProtobufTranslationEngine.java index 6a45a73..fd3b957 100644 --- a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/AT_ProtobufTranslationEngine.java +++ b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/AT_ProtobufTranslationEngine.java @@ -31,7 +31,7 @@ import gov.hhs.aspr.ms.taskit.core.testsupport.testobject.TestAppObject; import gov.hhs.aspr.ms.taskit.core.testsupport.testobject.translationSpecs.TestObjectTranslationSpec; import gov.hhs.aspr.ms.taskit.protobuf.testsupport.TestObjectUtil; -import gov.hhs.aspr.ms.taskit.protobuf.testsupport.testClasses.BadMessageBadArguements; +import gov.hhs.aspr.ms.taskit.protobuf.testsupport.testClasses.BadMessageBadArguments; import gov.hhs.aspr.ms.taskit.protobuf.testsupport.testClasses.BadMessageIllegalAccess; import gov.hhs.aspr.ms.taskit.protobuf.testsupport.testClasses.BadMessageNoMethod; import gov.hhs.aspr.ms.taskit.protobuf.testsupport.testClasses.BadMessageNonStaticMethod; @@ -83,7 +83,7 @@ public void testGetAnyFromObjectAsSafeClass() { // preconditions - // no translationSpec was prodived for the parent class + // no translationSpec was provided for the parent class ContractException contractException = assertThrows(ContractException.class, () -> { ProtobufTranslationEngine protobufTranslationEngine2 = ProtobufTranslationEngine.builder() .addTranslationSpec(new TestProtobufComplexObjectTranslationSpec()).build(); @@ -212,9 +212,9 @@ public void testGetBuilderForMessage() { protobufTranslationEngine.getBuilderForMessage(BadMessageNonStaticMethod.class); }); - // class has a static newBuilder method but it takes arguements + // class has a static newBuilder method but it takes arguments assertThrows(RuntimeException.class, () -> { - protobufTranslationEngine.getBuilderForMessage(BadMessageBadArguements.class); + protobufTranslationEngine.getBuilderForMessage(BadMessageBadArguments.class); }); // class has a newBuilder method but it is not accessible @@ -259,7 +259,7 @@ public void testReadInput() throws IOException { assertEquals(ProtobufCoreTranslationError.INVALID_READ_INPUT_CLASS_REF, contractException.getErrorType()); - // precondition for the Runtime exceptions are convered by the tests: + // precondition for the Runtime exceptions are covered by the tests: // testGetBuilderForMessage() and testParseJson() } diff --git a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/TestObjectUtil.java b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/TestObjectUtil.java index bf16751..ca84f69 100644 --- a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/TestObjectUtil.java +++ b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/TestObjectUtil.java @@ -79,10 +79,10 @@ public static List getListOfInputObjects(int num) { public static TestAppObject getAppFromInput(TestInputObject inputObject) { TestAppObject appObject = new TestAppObject(); - TestComplexAppObject complextAppObject = getComplexAppFromComplexInput(inputObject.getTestComplexInputObject()); + TestComplexAppObject complexAppObject = getComplexAppFromComplexInput(inputObject.getTestComplexInputObject()); TestAppEnum testAppEnum = getTestAppEnumFromTestInputEnum(inputObject.getEnum()); - appObject.setTestComplexAppObject(complextAppObject); + appObject.setTestComplexAppObject(complexAppObject); appObject.setBool(inputObject.getBool()); appObject.setInteger(inputObject.getInteger()); appObject.setString(inputObject.getString()); @@ -92,10 +92,10 @@ public static TestAppObject getAppFromInput(TestInputObject inputObject) { } public static TestInputObject getInputFromApp(TestAppObject appObject) { - TestComplexInputObject complextInputObject = getComplexInputFromComplexApp(appObject.getTestComplexAppObject()); + TestComplexInputObject complexInputObject = getComplexInputFromComplexApp(appObject.getTestComplexAppObject()); TestInputEnum testInputEnum = getTestInputEnumFromTestAppEnum(appObject.getTestAppEnum()); - TestInputObject inputObject = TestInputObject.newBuilder().setTestComplexInputObject(complextInputObject) + TestInputObject inputObject = TestInputObject.newBuilder().setTestComplexInputObject(complexInputObject) .setBool(appObject.isBool()).setInteger(appObject.getInteger()).setString(appObject.getString()) .setEnum(testInputEnum).build(); @@ -115,21 +115,21 @@ public static TestAppChildObject getChildAppFromApp(TestAppObject appObject) { } public static TestComplexAppObject getComplexAppFromComplexInput(TestComplexInputObject inputObject) { - TestComplexAppObject complextAppObject = new TestComplexAppObject(); + TestComplexAppObject complexAppObject = new TestComplexAppObject(); - complextAppObject.setNumEntities(inputObject.getNumEntities()); - complextAppObject.setStartTime(inputObject.getStartTime()); - complextAppObject.setTestString(inputObject.getTestString()); + complexAppObject.setNumEntities(inputObject.getNumEntities()); + complexAppObject.setStartTime(inputObject.getStartTime()); + complexAppObject.setTestString(inputObject.getTestString()); - return complextAppObject; + return complexAppObject; } public static TestComplexInputObject getComplexInputFromComplexApp(TestComplexAppObject appObject) { - TestComplexInputObject complextInputObject = TestComplexInputObject.newBuilder() + TestComplexInputObject complexInputObject = TestComplexInputObject.newBuilder() .setNumEntities(appObject.getNumEntities()).setStartTime(appObject.getStartTime()) .setTestString(appObject.getTestString()).build(); - return complextInputObject; + return complexInputObject; } public static TestAppEnum getTestAppEnumFromTestInputEnum(TestInputEnum testInputEnum) { diff --git a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/BadMessageBadArguements.java b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/BadMessageBadArguments.java similarity index 72% rename from protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/BadMessageBadArguements.java rename to protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/BadMessageBadArguments.java index b649b74..6e71835 100644 --- a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/BadMessageBadArguements.java +++ b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/testsupport/testClasses/BadMessageBadArguments.java @@ -1,8 +1,8 @@ package gov.hhs.aspr.ms.taskit.protobuf.testsupport.testClasses; -public class BadMessageBadArguements { +public class BadMessageBadArguments { - private BadMessageBadArguements() { + private BadMessageBadArguments() { } diff --git a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/translationSpecs/AT_AnyTranslationSpec.java b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/translationSpecs/AT_AnyTranslationSpec.java index f000f68..9caf26b 100644 --- a/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/translationSpecs/AT_AnyTranslationSpec.java +++ b/protobuf/src/test/java/gov/hhs/aspr/ms/taskit/protobuf/translationSpecs/AT_AnyTranslationSpec.java @@ -55,7 +55,7 @@ public void testConvertInputObject() { assertEquals(expectedValue, obj); // preconditions - // the typeurl of the any is malformed + // the type url of the any is malformed RuntimeException runtimeException = assertThrows(RuntimeException.class, () -> { Any badAny = Any.newBuilder().setTypeUrl("badTypeUrl").build(); anyTranslationSpec.convertInputObject(badAny); @@ -72,7 +72,7 @@ public void testConvertInputObject() { assertEquals("Message is not assignable from " + TestInputEnum.class.getName(), runtimeException.getMessage()); - // the typeurl doesn't match the class of the packed message + // the type url doesn't match the class of the packed message // this is tested in the test: testUnpackMessage } @@ -109,7 +109,7 @@ public void testConvertAppObject() { AnyTranslationSpec anyTranslationSpec = new AnyTranslationSpec(); anyTranslationSpec.init(protobufTranslationEngine); - // app object coverted into any + // app object converted into any Integer value = 100; Int32Value expectedValue = Int32Value.of(value); @@ -121,10 +121,10 @@ public void testConvertAppObject() { // app enum converted into any by wrapping it in a WrapperEnumValue TestAppEnum appValue = TestAppEnum.TEST1; - TestInputEnum expecetedValue = TestInputEnum.TEST1; + TestInputEnum expectedValueEnum = TestInputEnum.TEST1; WrapperEnumValue wrapperEnumValue = WrapperEnumValue.newBuilder() - .setEnumTypeUrl(TestInputEnum.getDescriptor().getFullName()).setValue(expecetedValue.name()).build(); + .setEnumTypeUrl(TestInputEnum.getDescriptor().getFullName()).setValue(expectedValueEnum.name()).build(); expectedAny = Any.pack(wrapperEnumValue); @@ -133,7 +133,7 @@ public void testConvertAppObject() { assertEquals(expectedAny, actualAny); // by calling covert on an object that was already converted - // this case is specifcally used for + // this case is specifically used for // ProtobufTranslationEngine.testGetAnyFromObjectAsSafeClass actualAny = anyTranslationSpec.convertAppObject(wrapperEnumValue);