WA storage method differences of >365 days

[gmahadwar]

Lake Philpott & Dam OD2_8560_8630 has 513 days difference between storage methods
This is to investigate why within WaterAvailability_CaseStudies.Rmd

Could one of these end years cause a >365 day difference?
Answer: we trim for a warmup period, so this is unlikely to cause a problem unless something is in the last 3months of the run

 #Trim runfile
    syear = as.integer(min(dat$year))
    eyear = as.integer(max(dat$year))
    if (syear < (eyear - 2)) {
      sdate <- as.POSIXct(paste0(syear,"-10-01"))
      edate <- as.POSIXct(paste0(eyear,"-09-30"))
    } else {
      sdate <- as.POSIXct(paste0(syear,"-02-01"))
      edate <- as.POSIXct(paste0(eyear,"-12-31"))

We do calculate using calendar year:

      l90 <- loflows["90 Day Min"];
      ndx <- which.min(as.numeric(l90[,"90 Day Min"]));
      l90_Qout <- round(loflows[ndx,]$`90 Day Min`,6);
      l90_year <- loflows[ndx,]$`year`;
      l90yr_start <- as.POSIXct(paste0(l90_year,"-01-01")) #start of l90 year
      l90yr_end <- as.POSIXct(paste0(l90_year,"-12-31")) #end of l90 year
      datpd_90yr <- window( #data for the l90 year
        dat,
        start = l90yr_start,
        end = l90yr_end
      )

Other potential causes: