Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSP Regional Summary - potential map errors #1323

Open
2 of 5 tasks
gmahadwar opened this issue Jul 25, 2024 · 1 comment
Open
2 of 5 tasks

WSP Regional Summary - potential map errors #1323

gmahadwar opened this issue Jul 25, 2024 · 1 comment
Assignees

Comments

@gmahadwar
Copy link
Contributor

gmahadwar commented Jul 25, 2024

@megpritch This is the beginning of the regional summary potential map issues, that may or may not be data problems (in which case that wouldn't be for you to fix).
cc @rburghol , @COBrogan , @BrendanBrogan

BigSandy_UpperTennessee_1

  • 1.2.1 map- some orange basin lines within the region are grayed-out, near Lee and Scott., but these aren't tidal

BigSandy_UpperTennessee_2

  • 1.2.1 map- some orange basin lines within the region grayed-out, near Bristol

Chowan_1

  • 1.2.1 map- Some facilities outside the region in the grayed-out portion are included, near Mecklenburg
  • DUPLICATES: Table 1.1- Rows that are repeated: 22-25, 26-29, 72-80, 81-89, 90-98
    • This is a df generator issue showing up in Table 1, so not for megpritch

Chowan_2

  • 1.2.1 map- Some facilities outside the region in the grayed-out portion are included, near Southampton. Some facilities inside the region are grayed-out, in Surry.

SoutheastVirginia

  • Labels for legend are going above the title. Map is also quite squat, which may be why the legend does not have enough space

For the remaining regions, all notes / issues so far seem to be on the data side only. Updates to this issue can be provided if that changes.

@gmahadwar
Copy link
Contributor Author

@megpritch
Another option besides the above, is to work on why the render no longer works when we set featr_type = "source", instead of featr_type = "facility". We lost compatibility with that setting at some point along the way, and it would be nice to revive that for the locality level renders if still possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants