feat: #129 disables legend strategy by data items for single value,…

… pivot table, bar, gauge, and column chart
HABTec · Nov 19, 2024 · b0998f7 · b0998f7
1 parent 19dd829
commit b0998f7
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 19 deletions.
diff --git a/src/Components/DashboardItem.js b/src/Components/DashboardItem.js
@@ -2,7 +2,6 @@ import * as React from "react";
 import PropTypes from "prop-types";
 import Typography from "@mui/material/Typography";
 
-import { axisClasses } from "@mui/x-charts/ChartsAxis";
 import {
   PieChart,
   BarChart,
@@ -22,7 +21,6 @@ import {
   lineElementClasses,
   markElementClasses,
 } from "@mui/x-charts/LineChart";
-import { barElementClasses } from "@mui/x-charts/BarChart";
 import ShowChartIcon from "@mui/icons-material/ShowChart";
 import FormatListBulletedOutlinedIcon from "@mui/icons-material/FormatListBulletedOutlined";
 import SplitscreenIcon from "@mui/icons-material/Splitscreen";
@@ -522,14 +520,16 @@ function DashboardItem(props) {
         }
         if (chartType === "text") return <TextChart item={item} />;
         if (chartType === "bar") {
-          console.log("bar label:", chartInfo);
           //find the longest text in the series
           let longestText = 0;
           chartConfig.yAxis.categories.forEach((text) => {
             if (text.length > longestText) longestText = text.length;
           });
 
-          if (chartInfo.legend?.set?.legends.length > 0) {
+          if (
+            chartInfo.legend?.set?.legends.length > 0 &&
+            chartInfo.legend?.strategy != "BY_DATA_ITEM"
+          ) {
             let legendValues = chartInfo?.legend?.set?.legends.map(
               (leg) => leg.endValue
             );
@@ -639,7 +639,10 @@ function DashboardItem(props) {
             },
           };
 
-          if (chartInfo.legend?.set?.legends.length > 0) {
+          if (
+            chartInfo.legend?.set?.legends.length > 0 &&
+            chartInfo.legend?.strategy != "BY_DATA_ITEM"
+          ) {
             let legendValues = chartInfo?.legend?.set?.legends.map(
               (leg) => leg.endValue
             );
@@ -828,10 +831,13 @@ function DashboardItem(props) {
                         <TableCell
                           sx={{
                             backgroundColor:
-                              chartInfo?.legend?.set?.legends.find(
-                                (leg) =>
-                                  data >= leg.startValue && data < leg.endValue
-                              )?.color ?? "white",
+                              chartInfo?.legend?.strategy != "BY_DATA_ITEM"
+                                ? chartInfo?.legend?.set?.legends.find(
+                                    (leg) =>
+                                      data >= leg.startValue &&
+                                      data < leg.endValue
+                                  )?.color ?? "lightgray"
+                                : "white",
                           }}
                           key={"data" + i}
                           align="right"
@@ -868,7 +874,8 @@ function DashboardItem(props) {
       let argLength = chartInfo?.legend?.set?.legends.map(
         (leg) => (leg.endValue - leg.startValue) / 100
       );
-      let colors = chartInfo?.legend?.set?.legends.map((leg) => leg.color);
+      let colors =
+        chartInfo?.legend?.set?.legends.map((leg) => leg.color) ?? [];
       let needleColor =
         chartInfo?.legend?.set?.legends.find(
           (leg) => value >= leg.startValue && value < leg.endValue

diff --git a/src/Components/SingleValueChart.js b/src/Components/SingleValueChart.js
@@ -7,17 +7,21 @@ const SingleValueChart = ({ chartData, componentRef, chartInfo }) => {
   try {
     let value = chartData?.rows[0][1];
     let dataElement = chartData?.rows[0][0];
+    let textColor = "black";
+    let color = "primary";
 
-    let color = chartInfo?.legend?.set?.legends.find(
-      (leg) => value >= leg.startValue && value < leg.endValue
-    )?.color;
+    if (chartInfo.legend?.strategy != "BY_DATA_ITEM") {
+      color = chartInfo?.legend?.set?.legends.find(
+        (leg) => value >= leg.startValue && value < leg.endValue
+      )?.color;
 
-    let textColor =
-      chartInfo?.legend?.style == "FILL" ? "black" : color || "black";
-    if (chartInfo?.legend?.style == "FILL") {
-      componentRef.current.style.backgroundColor = color;
-      componentRef.current.firstChild.firstChild.firstChild.style.color =
-        "black";
+      textColor =
+        chartInfo?.legend?.style == "FILL" ? "black" : color || "black";
+      if (chartInfo?.legend?.style == "FILL") {
+        componentRef.current.style.backgroundColor = color;
+        componentRef.current.firstChild.firstChild.firstChild.style.color =
+          "black";
+      }
     }
 
     let title =