Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configs of read/write cache #5233

Open
waynexia opened this issue Dec 25, 2024 · 0 comments
Open

Refactor configs of read/write cache #5233

waynexia opened this issue Dec 25, 2024 · 0 comments
Labels
C-enhancement Category Enhancements

Comments

@waynexia
Copy link
Member

What type of enhancement is this?

Configuration

What does the enhancement do?

Two major file caches in DB are

  • read cache, belongs to storage
  • write cache, belongs to mito2

And the write cache is marked as "experimental", which should be stable now. This ticket proposes to change all file-related cache configurations to

  • storage.cache_path, default to data_home
  • storage.cache_capacity, default 10GB. Includes both write cache and read cache.
  • (optional) storage.read_cache_capacity which will override storage.cache_capacity
  • (optional) storage.write_cache_capacity which will override storage.cache_capacity

Two optional cache capacities are for advanced users who want to fine-tune their cache usage. Capacity set to 0 stands for disabling the cache.

Implementation challenges

This requires a code refactor to extract the write cache from mito engine.

@waynexia waynexia added the C-enhancement Category Enhancements label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

1 participant