Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Loki proto #5122

Open
shuiyisong opened this issue Dec 9, 2024 · 0 comments
Open

Update Loki proto #5122

shuiyisong opened this issue Dec 9, 2024 · 0 comments
Labels
C-enhancement Category Enhancements

Comments

@shuiyisong
Copy link
Contributor

What type of enhancement is this?

API improvement

What does the enhancement do?

greptimedb/src/servers/Cargo.toml

Line 69 in c0f498b

loki-api = "0.1"

We use loki-api to introduce Loki rs proto. definition However it's out of date now. We might need to update the proto in one way or another.

Implementation challenges

Possible solutions:

  1. fork the loki-api repo and update the proto file.
  2. copy and maintain the proto file directly in our codebase like vector does
@shuiyisong shuiyisong added C-enhancement Category Enhancements good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category Enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shuiyisong