Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update partition duration of memtable using compaction window #5197

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: update partition duration of memtable using compaction window #5197

wants to merge 5 commits into from
+258 −21

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Dec 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

fixes #5098

What's changed and what's your intention?

This PR tries to create a new mutable memtable with the latest compaction time window. It sets the part_duration of the TimePartitions when a region freezes its memtables.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 18, 2024
@evenyag evenyag marked this pull request as ready for review December 20, 2024 09:04
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.16590% with 17 lines in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (548e198) to head (3f15eb8).
Report is 32 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5197      +/-   ##
==========================================
- Coverage   84.14%   83.86%   -0.28%     
==========================================
  Files        1177     1184       +7     
  Lines      218960   220074    +1114     
==========================================
+ Hits       184234   184556     +322     
- Misses      34726    35518     +792

@waynexia waynexia requested a review from Copilot December 26, 2024 03:08
Copilot
Copilot AI reviewed Dec 26, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/mito2/src/engine/compaction_test.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/mito2/src/memtable/time_partition.rs:570

  • [nitpick] The function name test_write_multi_parts is not very descriptive. Consider renaming it to test_write_multiple_partitions.
fn test_write_multi_parts() {

src/mito2/src/memtable/version.rs:108

  • Ensure that the time_window parameter is correctly propagated and used in the fork function.
let mutable = Arc::new(self.mutable.fork(metadata, time_window));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r v0y4g3r is a code owner

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply time window to memtables after compaction
1 participant
@evenyag