Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter inverted index #5059

Open
killme2008 opened this issue Nov 27, 2024 · 4 comments
Open

Alter inverted index #5059

killme2008 opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
C-feature Category Features help wanted Extra attention is needed
Milestone

Comments

@killme2008
Copy link
Contributor

What problem does the new feature solve?

Since v0.10, the INVERTED INDEX constraint can be used to specify the columns that need the inverted index

See https://docs.greptime.com/reference/sql/create/#inverted-index

But we are unable to add or remove a column from INVERTED INDEX.

For example:

-- add load_15 to inverted indexes--
ALTER TABLE monitor MODIFY COLUMN load_15  SET INVERTED INDEX;
-- remove load_15 from inverted indexes--
ALTER TABLE monitor MODIFY COLUMN load_15  UNSET INVERTED INDEX;

What does the feature do?

As the above said.

Implementation challenges

No response

@killme2008 killme2008 added C-feature Category Features help wanted Extra attention is needed labels Nov 27, 2024
@fengjiachun fengjiachun added this to the v0.11 milestone Nov 27, 2024
@lyang24
Copy link
Collaborator

lyang24 commented Nov 28, 2024

can i take this issue? is the implementation similar to alter table column with fulltext option like 4952?

@CookiePieWw
Copy link
Collaborator

can i take this issue? is the implementation similar to alter table column with fulltext option like #4952?

Sure :) It's quite similar. BTW, I‘d like to recommend unifying related structs like:

SetIndex {
  FULLTEXT,
  INVERTED,
}

which is better for further extenstions.

@lyang24 lyang24 self-assigned this Dec 4, 2024
@lyang24
Copy link
Collaborator

lyang24 commented Dec 4, 2024

I believe we need to add to proto for AlterTableExpr as a prerequisite before working on this one. Can i get a review with this pr?
https://github.com/GreptimeTeam/greptime-proto/pull/204/files

@CookiePieWw
Copy link
Collaborator

I believe we need to add to proto for AlterTableExpr as a prerequisite before working on this one. Can i get a review with this pr?

We can first use the commit hash in GreptimeTeam/greptime-proto#204, and merge it after the pr in greptimedb is ready for merge.

@fengjiachun fengjiachun modified the milestones: v0.11, v0.12 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category Features help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants