Skip to content

Commit b967b73

Browse files
committed
choer: more fix
Signed-off-by: discord9 <[email protected]>
1 parent 69d2662 commit b967b73

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

src/meta-srv/src/gc/handler.rs

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -441,14 +441,13 @@ impl GcScheduler {
441441
retry_round: usize,
442442
) -> Result<(Region2Peers, Peer2Regions)> {
443443
let all_related_regions = self
444-
.find_related_regions(&regions)
444+
.find_related_regions(regions)
445445
.await?
446446
.into_iter()
447-
.map(|(k, mut v)| {
447+
.flat_map(|(k, mut v)| {
448448
v.push(k);
449449
v
450450
})
451-
.flatten()
452451
.collect_vec();
453452
let mut region_to_peer = HashMap::new();
454453
let mut peer_to_regions = HashMap::new();
@@ -503,19 +502,19 @@ impl GcScheduler {
503502

504503
// Find the region in the table route
505504
for region_route in &table_route.region_routes {
506-
if region_route.region.id == region_id {
507-
if let Some(leader_peer) = &region_route.leader_peer {
508-
region_to_peer.insert(
509-
region_id,
510-
(leader_peer.clone(), region_route.follower_peers.clone()),
511-
);
512-
peer_to_regions
513-
.entry(leader_peer.clone())
514-
.or_default()
515-
.insert(region_id);
516-
found = true;
517-
break;
518-
}
505+
if region_route.region.id == region_id
506+
&& let Some(leader_peer) = &region_route.leader_peer
507+
{
508+
region_to_peer.insert(
509+
region_id,
510+
(leader_peer.clone(), region_route.follower_peers.clone()),
511+
);
512+
peer_to_regions
513+
.entry(leader_peer.clone())
514+
.or_default()
515+
.insert(region_id);
516+
found = true;
517+
break;
519518
}
520519
}
521520

src/meta-srv/src/gc/mock/err_handle.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ async fn test_get_table_route_failure() {
269269
let report = scheduler
270270
.process_datanodes_with_retry(datanode_to_candidates)
271271
.await;
272-
dbg!(&report);
272+
273273
// Should process the datanode but handle route error gracefully
274274
assert_eq!(
275275
report.per_datanode_reports.len(),

src/meta-srv/src/gc/mock/retry.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@ async fn test_need_retry_regions_exponential_backoff() {
440440
// Extract the datanode report from the job report
441441
let report = job_report.per_datanode_reports.get(&peer.id).unwrap();
442442

443-
dbg!(&report);
444443
// Verify results
445444
assert!(report.deleted_files.contains_key(&region_id));
446445
assert!(report.need_retry_regions.is_empty());

0 commit comments

Comments
 (0)