From fab89ca9914d1e85ceb73c9faf16348720befa97 Mon Sep 17 00:00:00 2001 From: liyang Date: Wed, 14 Aug 2024 22:01:02 +0800 Subject: [PATCH] fix: omit tables length check --- examples/object/main.go | 2 +- request/request.go | 2 +- schema/field.go | 3 --- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/examples/object/main.go b/examples/object/main.go index 0f6b0d8..b416da1 100644 --- a/examples/object/main.go +++ b/examples/object/main.go @@ -53,7 +53,7 @@ func (Monitor) TableName() string { func initData() []Monitor { return []Monitor{ { - Host: "127.0.0.1", + //Host: "127.0.0.1", Memory: 1, Cpu: 1.3, Temperature: -1, diff --git a/request/request.go b/request/request.go index d46366d..e07b9fe 100644 --- a/request/request.go +++ b/request/request.go @@ -52,7 +52,7 @@ func (r *Request) WithTables(tables ...*table.Table) *Request { } func (r *Request) IsZero() bool { - return r.tables == nil || len(r.tables) == 0 + return r.tables == nil } func (r *Request) Build() (*gpb.GreptimeRequest, error) { diff --git a/schema/field.go b/schema/field.go index 9fc9a79..5fbb9c4 100644 --- a/schema/field.go +++ b/schema/field.go @@ -183,9 +183,6 @@ func parseValue(typ gpb.ColumnDataType, val reflect.Value) (*gpb.Value, error) { if !val.IsValid() { return nil, nil } - if val.Kind() == reflect.Pointer && val.IsNil() { - return nil, nil - } switch typ { case gpb.ColumnDataType_INT8, gpb.ColumnDataType_INT16, gpb.ColumnDataType_INT32, gpb.ColumnDataType_INT64: