Skip to content

Commit 3004c00

Browse files
authored
Release V1.1 (#36)
* update logo * pin pillow version to 7.0.0 pillow 7.1.1 caused an incompatibility with scikit-image ImageCollections thanks @bisnow33 for reporting the issue * unpin pillow regression was fixed in pillow release 7.1.2 * remove error strategy for local runs Previously, a job that failed because of insufficient memory was resubmitted 3 times and resource requirements were increased for each attempt. e.g run_predictions required: - 2 CPUs and 6GB RAM for the first attempt - 4 CPUs and 12GB RAM for the second attempt - 6 CPUs and 18GB RAM for the third attempt While such a strategy makes sense in a cluster environment, where increased resource requests can be satisfied, it makes little sense on a local computer with given hardware limitations. This commit removes the error strategy for local pipeline runs. * enable integration tests when pushing to dev * fix display of shiny server IP on macOS Previously, the logic assumed that `hostname -i` returns the local ip address of the host. Apparently this is not the case on MacOS, thus fall back to localhost on these systems. * (attempt to) fix string conversion of uname output * add CHANGELOG.md * set version tags for 1.1 release
1 parent dacba90 commit 3004c00

File tree

9 files changed

+21
-12
lines changed

9 files changed

+21
-12
lines changed

.github/workflows/minimal_test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ on:
77
push:
88
branches-ignore:
99
- master
10-
- dev
1110

1211
jobs:
1312
test:

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Changelog
2+
3+
## [v1.1](https://github.com/Gregor-Mendel-Institute/aradeepopsis/releases/tag/v1.1) - 2020-05-13
4+
5+
* disabled task error strategy for pipeline runs on local computers
6+
* fixed an issue where the network address of the shiny application was not correctly displayed on computers running MacOS
7+
8+
## [v1.0](https://github.com/Gregor-Mendel-Institute/aradeepopsis/releases/tag/v1.0) - 2020-04-02
9+
10+
Initial pipeline release

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ LABEL authors="[email protected]" \
66
COPY environment.yml /
77
RUN apt-get update && apt-get install -y procps graphviz && apt-get clean -y
88
RUN conda env create -f /environment.yml && conda clean -afy
9-
ENV PATH /opt/conda/envs/aradeepopsis-v1.0/bin:$PATH
9+
ENV PATH /opt/conda/envs/aradeepopsis-v1.1/bin:$PATH
1010

1111
EXPOSE 44333

conf/base.config

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,8 @@ env {
2626
}
2727

2828
process {
29-
container = 'beckerlab/aradeepopsis:1.0'
29+
container = 'beckerlab/aradeepopsis:1.1'
3030

31-
errorStrategy = { task.exitStatus in [104,134,135,137,139,140,143] ? 'retry' : 'finish' }
32-
maxRetries = 3
33-
3431
withName: build_records {
3532
cpus = { 1 * task.attempt }
3633
memory = { 2.GB * task.attempt }

conf/cbe.config

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ process {
2929
queue = 'c'
3030
clusterOptions = { task.time <= 8.h ? '--qos short': task.time <= 48.h ? '--qos medium' : '--qos long' }
3131

32+
errorStrategy = { task.exitStatus in [104,134,135,137,139,140,143] ? 'retry' : 'finish' }
33+
maxRetries = 3
34+
3235
withName: build_records {
3336
cpus = { 1 * task.attempt }
3437
memory = { 1.GB * task.attempt }

docs/parameters.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,6 @@ Launch a [Shiny](https://shiny.rstudio.com/) app in the last step of the pipelin
8989
> R -e "shiny::runApp('app.R', port=44333)"
9090
>
9191
> # if using the container image
92-
> {docker|podman} run -v $(pwd):/mnt/shiny -p 44333:44333 beckerlab/aradeepopsis:1.0 R -e "shiny::runApp('/mnt/shiny/app.R', port=44333, host='0.0.0.0')"
92+
> {docker|podman} run -v $(pwd):/mnt/shiny -p 44333:44333 beckerlab/aradeepopsis:1.1 R -e "shiny::runApp('/mnt/shiny/app.R', port=44333, host='0.0.0.0')"
9393
> ```
94-
> The shiny app can then be opened with a browser by typing localhost:44333 in the address bar. It will terminate when the browser window is closed.
94+
> The shiny app can then be opened with a browser by typing localhost:44333 in the address bar. It will terminate when the browser window is closed.

environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: aradeepopsis-v1.0
1+
name: aradeepopsis-v1.1
22
channels:
33
- conda-forge
44
- r

main.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,6 @@ ch_results
316316
.set {ch_resultfile}
317317

318318
process launch_shiny {
319-
tag "${'http://'+'hostname -i'.execute().text.trim()+':44333'}"
320319
containerOptions { workflow.profile.contains('singularity') ? '' : '-p 44333:44333' }
321320
executor 'local'
322321
cache false
@@ -327,8 +326,9 @@ process launch_shiny {
327326
when:
328327
params.shiny
329328
script:
329+
def ip = "uname".execute().text.trim() == "Darwin" ? "localhost" : "hostname -i".execute().text.trim()
330330
log.error"""
331-
Visit the shiny server running at ${"http://"+"hostname -i".execute().text.trim()+':44333'} to inspect the results.
331+
Visit the shiny server running at ${"http://"+ip+':44333'} to inspect the results.
332332
Closing the browser window will terminate the pipeline.
333333
""".stripIndent()
334334
"""

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ manifest {
5252
homePage = 'https://github.com/Gregor-Mendel-Institute/aradeepopsis'
5353
description = "Nextflow pipeline to run semantic segmentation on plant rosette images with DeepLab V3+"
5454
name = 'aradeepopsis'
55-
version = '1.0'
55+
version = '1.1'
5656
mainScript = 'main.nf'
5757
nextflowVersion = '>=20.01.0'
5858
}

0 commit comments

Comments
 (0)