New profile drawer merge #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuspenseFallback if possible I hope we can use some components rather than do it by ourselves, but you got some for that? Can you explain? |
|
With a div it is easier to implement the moving function because we can customize the transition speed, width, etc. With the MUI drawer component, it is much harder to implement the moving UI. |
dadiorchen
approved these changes
Oct 16, 2023
|
@SuspenseFallback thank you for your explanation, I approved your code, but we now migrated the code to this one https://github.com/Greenstand/treetracker-web-map-core-demo , can you copy your change to it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7
Fixed some issues related to navbar, made it responsive (not for screens less than 360px, I need some help with that)
Also made the content move using
<div>instead of<Grid>and<Drawer>