Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method for removing custom event listeners #134

Open
Mohmn opened this issue Nov 12, 2022 · 4 comments · May be fixed by #144
Open

add method for removing custom event listeners #134

Mohmn opened this issue Nov 12, 2022 · 4 comments · May be fixed by #144

Comments

@Mohmn
Copy link
Member

Mohmn commented Nov 12, 2022


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@Mohmn Mohmn changed the title add method for removing event listener add method for removing custom event listeners Nov 12, 2022
@dadiorchen
Copy link
Collaborator

Yes, this is good, now we are using node built-in (if I can say this way) event API to handle the event listener, so it seems easy to expose something @Mohmn required in this issue.

https://nodejs.org/api/events.html

@Mohmn
Copy link
Member Author

Mohmn commented Nov 14, 2022

@dadiorchen yep its pretty straight forward, should i do it myself or leave it for the new contributors

@dadiorchen
Copy link
Collaborator

I hope you can take it, it is not a easy one

@Mohmn
Copy link
Member Author

Mohmn commented Nov 15, 2022

I hope you can take it, it is not a easy one

I will give it a go then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants