Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test in cwm branch #1672

Open
dadiorchen opened this issue Jul 3, 2023 · 4 comments
Open

Fix broken test in cwm branch #1672

dadiorchen opened this issue Jul 3, 2023 · 4 comments
Labels
Cypress feature:cwm-theme-editor Customizable Web Map Theme Editor good first issue Good for newcomers TDD

Comments

@dadiorchen
Copy link
Collaborator

in this PR, #1668
The ci reported error: https://github.com/Greenstand/treetracker-web-map-client/actions/runs/5430146328?pr=1668

We need to fix them.


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added good first issue Good for newcomers Cypress TDD feature:cwm-theme-editor Customizable Web Map Theme Editor labels Jul 3, 2023
@dadiorchen
Copy link
Collaborator Author

@RubenSmn I just open the CI for branches now, seems there are some broken test in cwm

@RubenSmn
Copy link
Member

@dadiorchen are we using the .env.test env file when running the tests? The flag that we use to disable the feature of getting the theme from the backend is correct. Could it be that we're using the .env.development env file when running the tests?

@dadiorchen
Copy link
Collaborator Author

Yea, I think we are using .env.development, I don't remember anything about .env.test related.

About the error, the unit test problem is easy, just we need to fix something related to cwm code.

For the integration test, I hope you can run it locally on the cwm branch, if that works on your side, I can help to find out what' cause the problem in this CI

@dadiorchen
Copy link
Collaborator Author

We we finished this, then we can use the CI to protect the cwm branch, I think this is meaniful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress feature:cwm-theme-editor Customizable Web Map Theme Editor good first issue Good for newcomers TDD
Projects
None yet
Development

No branches or pull requests

2 participants