Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement API: GET /countries/leaderboard?continent=Asia #51

Open
dadiorchen opened this issue Jan 20, 2022 · 4 comments · May be fixed by #88
Open

Implement API: GET /countries/leaderboard?continent=Asia #51

dadiorchen opened this issue Jan 20, 2022 · 4 comments · May be fixed by #88
Labels
Express good first issue Good for newcomers medium Node.js postgresql

Comments

@dadiorchen
Copy link
Contributor

To implement an endpoint:
Implement API: GET /countries/leaderboard?continent=Asia

  • Please write an e2e test to cover it.
  • Please follow the guide in the 'readme' to follow our architecture on the server-side.

Note, the leaderboard has been created, but don't support query: continent=name, so the goal of this issue is to filter the leaderboard by continent name

Some hints:

  • Please read our readme for more information/guide/tutorial.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen
Copy link
Contributor Author

Also, you will find we 'hard code' the data in the API, that's just for that we are able to return the data quickly, so the development experience is good on the client side, please restore the real SQL query and add your code

@dadiorchen
Copy link
Contributor Author

We will figure out a way to speed up the performance like a SQL cache.

@pierrelstan
Copy link
Contributor

@dadiorchen I will work on this one

@dadiorchen
Copy link
Contributor Author

Welcome to the GIS world :D

@pierrelstan pierrelstan linked a pull request Feb 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Express good first issue Good for newcomers medium Node.js postgresql
Projects
No open projects
Web Map Application
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#51: feat: implement get countries leaderboard pierrelstan/treetracker-query-api
2 participants
@dadiorchen @pierrelstan