Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Certificate to Api Models and Tree Details View (App Drawer) #68

Closed
gloriaLVela opened this issue Mar 11, 2019 · 0 comments
Closed

Comments

@gloriaLVela
Copy link
Member

@thiagodemellobueno thiagodemellobueno created this issue from a note in Tree-Tracker Admin (To do) on Jun 20, 2018
@thiagodemellobueno thiagodemellobueno added API help wanted good first issue labels on Jun 20, 2018
@madhu-kumari
Member
madhu-kumari commented on Sep 21, 2018
Hi...I would like to work on this issue. Is it possible for you to provide more information on this requirement?

@thiagodemellobueno thiagodemellobueno changed the title Introduce Orgs to API Introduce Orgs to tree Details View (App Drawer) on Sep 25, 2018
@thiagodemellobueno
Member Author
thiagodemellobueno commented on Sep 25, 2018
With this PR:
#52
(Which has been merged)
@nimblefox has introduced the tree details drawer, and done some preliminary rendering of the same.

As for getting the "relation" information back from the api here is some documentation:
https://loopback.io/doc/en/lb2/Querying-related-models.html
https://loopback.io/doc/en/lb2/Include-filter.html

So this issue becomes more about updating the queries to include the related data, and echo it in the app drawer, which is now pretty straightforward.

@thiagodemellobueno
Member Author
thiagodemellobueno commented on Sep 25, 2018
Please consider #49 as well :)

@madhu-kumari
Member
madhu-kumari commented on Sep 25, 2018
I would like to clarify my understanding. Let me know if I am doing anything wrong.

Take fresh code from the repository.
npm install
npm start
4)Check the live server at localhost:3000
Select any id, a panel from the right side appears
The panel contains a tree image, and 3 other details (Location, Status, Missing )
Do I need to modify the API and get additional information that needs to be displayed in this panel?
If yes, what other parameters I need to fetch (any API level changes)?
Or do I need to just render the API and fetch values (No API level changes)?
Once these values are fetched, they need to be displayed in the same tree panel with the 3 other details.
@madhu-kumari
Member
madhu-kumari commented on Sep 25, 2018
Thanks for providing the loopback docs. will try to get hands-on.

@thiagodemellobueno thiagodemellobueno assigned madhu-kumari on Sep 25, 2018
@thiagodemellobueno thiagodemellobueno moved this from To do to In progress in Tree-Tracker Admin on Sep 25, 2018
@thiagodemellobueno thiagodemellobueno changed the title Introduce Orgs to tree Details View (App Drawer) Introduce Certificate to Api Models and Tree Details View (App Drawer) on Sep 27, 2018
@thiagodemellobueno
Member Author
thiagodemellobueno commented on Sep 27, 2018
Hello @madhu-kumari. As per a quick conversation with @deepwinter (Zaven), the way we are now talking about "grouping" a tree by donor is a certificate see certificateId - see - http://dev.treetracker.org/api/admin/Trees/6
trees do have donor but "you get the donor by joining the certificates and donors table" - so we'll probably need to expose both donors and certificates in the api over at common/models.

@thiagodemellobueno
Member Author
thiagodemellobueno commented on Sep 27, 2018
https://files.slack.com/files-pri/T6WR1QS8J-FD20MDTHP/image.png

@thiagodemellobueno thiagodemellobueno referenced this issue on Sep 27, 2018
Open
Include planters in Tree Details View (App Drawer) #49
@thiagodemellobueno thiagodemellobueno unassigned madhu-kumari on Nov 29, 2018
@thiagodemellobueno thiagodemellobueno moved this from In progress to Ready to be worked on in Tree-Tracker Admin on Nov 29, 2018

@ZavenArra ZavenArra transferred this issue from Greenstand/treetracker-admin-api Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants