From 37b7f677bb81a663ab8275a98f1637d0dd287ef2 Mon Sep 17 00:00:00 2001
From: Linus Pahl <linus.pahl@graylog.com>
Date: Tue, 25 Jun 2024 14:17:19 +0200
Subject: [PATCH 1/2] Always display input for widget title in widget edit
 mode.

---
 .../src/views/components/widgets/Widget.tsx   |  1 +
 .../views/components/widgets/WidgetHeader.tsx | 39 ++++++++++++++++++-
 2 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/graylog2-web-interface/src/views/components/widgets/Widget.tsx b/graylog2-web-interface/src/views/components/widgets/Widget.tsx
index 6d57c9f0013a..29fdfc74b25d 100644
--- a/graylog2-web-interface/src/views/components/widgets/Widget.tsx
+++ b/graylog2-web-interface/src/views/components/widgets/Widget.tsx
@@ -259,6 +259,7 @@ const Widget = ({ id, editing, widget, title, position, onPositionsChange }: Pro
             <WidgetHeader title={title}
                           hideDragHandle={!interactive || isFocused}
                           loading={loading}
+                          editing={editing}
                           onRename={onRenameWidget}>
               {!editing ? (
                 <WidgetActionsMenu isFocused={isFocused}
diff --git a/graylog2-web-interface/src/views/components/widgets/WidgetHeader.tsx b/graylog2-web-interface/src/views/components/widgets/WidgetHeader.tsx
index 15353c0882f1..65f7be707b1d 100644
--- a/graylog2-web-interface/src/views/components/widgets/WidgetHeader.tsx
+++ b/graylog2-web-interface/src/views/components/widgets/WidgetHeader.tsx
@@ -20,6 +20,7 @@ import styled, { css } from 'styled-components';
 
 import { Spinner, Icon } from 'components/common';
 import EditableTitle from 'views/components/common/EditableTitle';
+import { Input } from 'components/bootstrap';
 
 import CustomPropTypes from '../CustomPropTypes';
 
@@ -34,6 +35,11 @@ const Container = styled.div(({ theme }) => css`
   display: grid;
   grid-template-columns: minmax(35px, 1fr) max-content;
   align-items: center;
+
+  .widget-title {
+    width: 100%;
+    max-width: 400px;
+  }
 `);
 
 const Col = styled.div`
@@ -57,19 +63,48 @@ const WidgetActionDropdown = styled.span`
   position: relative;
 `;
 
+const TitleInputWrapper = styled.div`
+  max-width: 400px;
+  width: 100%;
+
+  .form-group {
+    margin-bottom: 5px;
+    width: 100%;
+  }
+`;
+
+const TitleInput = styled(Input)(({ theme }) => css`
+  font-size: ${theme.fonts.size.large};
+  width: 100%;
+`);
+
 type Props = {
   children: React.ReactNode,
   onRename: (newTitle: string) => unknown,
   hideDragHandle: boolean,
   title: string,
   loading: boolean,
+  editing: boolean,
 };
 
-const WidgetHeader = ({ children, onRename, hideDragHandle, title, loading }: Props) => (
+const WidgetHeader = ({ children, onRename, hideDragHandle, title, loading, editing }: Props) => (
   <Container>
     <Col>
       {hideDragHandle || <DragHandleContainer className="widget-drag-handle" title={`Drag handle for ${title}`}><WidgetDragHandle name="drag_indicator" /></DragHandleContainer>}
-      <EditableTitle key={title} disabled={!onRename} value={title} onChange={onRename} />
+      {editing ? (
+        <TitleInputWrapper>
+          <TitleInput type="text"
+                      id="widget-title"
+                      onChange={(e) => onRename(e.target.value)}
+                      value={title}
+                      required />
+        </TitleInputWrapper>
+      ) : (
+        <EditableTitle key={title}
+                       disabled={!onRename}
+                       value={title}
+                       onChange={onRename} />
+      )}
       {loading && <LoadingSpinner text="" delay={0} />}
     </Col>
     <WidgetActionDropdown>

From 167d92e96a093a13d5d25d9908588d2e4cca2f92 Mon Sep 17 00:00:00 2001
From: Linus Pahl <linus.pahl@graylog.com>
Date: Tue, 25 Jun 2024 14:39:07 +0200
Subject: [PATCH 2/2] Adding changelog.

---
 changelog/unreleased/issue-7396.toml | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 changelog/unreleased/issue-7396.toml

diff --git a/changelog/unreleased/issue-7396.toml b/changelog/unreleased/issue-7396.toml
new file mode 100644
index 000000000000..c057db06b8bc
--- /dev/null
+++ b/changelog/unreleased/issue-7396.toml
@@ -0,0 +1,5 @@
+type="c"
+message="Always display input for widget title in widget edit mode."
+
+issues=["7396"]
+pulls=["19737"]