Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for untrusted CAs in datanode remote reindex migration #19775

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Jun 28, 2024

Description

This PR is adding support for untrusted certificate authorities during the remote reindex migration to the datanode. The connection check step is now reporting that none of our trust managers is trusting the remote host. Then, user can ✔️ the trust unknown certificates checkbox. Connection check is then using a trust manager that accepts all certificates and reports unknown. These unknown certificates are then transported, together with the allowlist value, to the datanode. Datanode takes these certificates and adds them to its truststore. The truststore is regenerated during each startup, so these certificates will disappear with the next process restart and won't stay there forever.

Motivation and Context

Fixes #19759

How Has This Been Tested?

Manually, added unit tests.

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review June 28, 2024 08:44
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM. Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Data node does not start up successfully after importing custom CA.
2 participants