Apply Transform node produces the wrong result on shapes with handles

[Keavon]

Just add an Apply Transform node to a shape and it becomes messed up unless it has a (0, 0) translation if the shape has handles. If it's only a polyline, it is unaffected (the polygon at the end of the video below was affected until #3606 was fixed).

capture.mp4

The Apply Transform node is supposed to keep the geometric form the same, just changing its geometry and transform space.

I don't recall this being broken in the past, so it might be a regression.

[chintu4]

i will try to resolve this issue in node-graph>nodes>vector>src>vector_modification_nodes.rs or node-graph/nodes/vector/src/vector_modification_nodes.rs in apply_transform function code

// Old code (simplified)
for (_, point) in vector.point_domain.positions_mut() {
    *point = transform.transform_point2(*point);
}
// Transform was reset to Identity, leaving handles behind in the old coordinate space.

adding more 4 lines in the same function should resolve this issue

// New code
for (handles, _start_index, _end_index) in vector.segment_domain.handles_and_points_mut() {
    *handles = handles.apply_transformation(|p| transform.transform_point2(p));
}

Iam confirming changes i have done.

I cannot reproduce this issue on https://editor.graphite.art
is this issue on desktop @Keavon

[Keavon]

@chintu4 https://dev.graphite.art is the latest master