-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work-week ends do not seem to be calculated correctly #49
Comments
Sigh. I said #66 partially resolves this, Github. We still need to fix / discuss the "It seems to consider the next "work week" to have already begun on Saturday" aspect of this bug report. |
These look correct now for weekend days such as today, except that
because, my assertion is, the next work week doesn't actually start until Monday, so the "previous" work week is still the one before this week's Monday. Even though it's after the end of the "work week" (I guess Friday), it's before the beginning of the next one.. All of the following
prior to your patch there were 3 false and a 1 true so it's closer ;-) |
Work week endings may be calculated incorrectly. Observe the following:
with the reference date of 2017-03-05 12:34:56 (a Sunday), and the calendar:
these do not look right:
soww
andsonww
are identicaleoww
is earlier thansoww
(!)This issue was noticed during testing for #47 (a change to comments documenting behavior of
eo*
) and is forked into a standalone issue as per the discussion there.(test version of
libshared
was 591fa58)The text was updated successfully, but these errors were encountered: