Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeshift and movingaverage functions & improve docker-compose #145

Closed
wants to merge 0 commits into from

Conversation

giom-l
Copy link

@giom-l giom-l commented Mar 3, 2022

fix #128
This PR is to fix the moving average & timeshift function as proposed in #128
Credits for this go to drsoares

I tested this fix against version from 8.3.4 to 8.4.3 and it worked for me everytime.
I also improved the docker-compose part :

  • Use a local volume to store grafana data (and prevent loss after container restart)
  • Provision a grafana.ini config where the plugin is allowed as unsigned plugin (without it, it won't load in latest grafana versions)

If this PR is acceptable :

  • the plugin should be properly signed to avoid having to state it as unsigned for it to work
  • could you please release a proper grafana plugin to we can install it in grafana cloud and through grafana-cli (maybe add a CI part to do this automatically when a tag is created ? )

@ShilpaSivanesan
Copy link
Contributor

@giom-l could you please pull the latest master and update PR

@giom-l
Copy link
Author

giom-l commented Mar 8, 2022

Sure, since I kinda messed up with my repo, I created a new PR : #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants