Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org chart is broken #205

Closed
Hareesh-kumar-kuruba opened this issue Nov 22, 2017 · 1 comment
Closed

org chart is broken #205

Hareesh-kumar-kuruba opened this issue Nov 22, 2017 · 1 comment
Labels
bug duplicate

Comments

@Hareesh-kumar-kuruba
Copy link

Hareesh-kumar-kuruba commented Nov 22, 2017 •
edited
Loading

I had google-chart of type orgchart in my polymer project.It was working fine in my 1.x polymer project. While updating my polymer project to 2.0 it was broken. I tried the example given in demo in new project, there also it is broken. It looks like the below pic where connectors are missing
screencapture-127-0-0-1-8000-chart-test-html-1511350086208

And my code is

`<!doctype html>
<!-- Copyright (c) 2014 Google Inc. All rights reserved. -->
<html>
<head>
    <meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
    <title>google-chart Demo</title>

    <script src="bower_components/webcomponentsjs/webcomponents-lite.js"></script>
    <link rel="import" href="bower_components/promise-polyfill/promise-polyfill-lite.html">
    <link rel="import" href="bower_components/google-chart/google-chart.html">
    <style>
        code {
            color: #007000;
        }

        google-chart {
            height: 300px;
            width: 400px;
        }
    </style>

</head>
<body>


<p>Here's a organization chart:</p>

<google-chart
        id="org-chart",
        type="org",
        options='{"allowHtml": "true"}'
        cols='[{"label": "Name", "type": "string"},{"label":"Manager", "type":"string"},{"label":"ToolTip", "type":"string"}]'
        rows='[[{"v":"Mike", "f":"Mike<div style=\"color:red; font-style:italic\">President</div>"},
            "", "The President"],
            [{"v":"Jim", "f":"Jim<div style=\"color:red; font-style:italic\">Vice President</div>"},
            "Mike", "VP"],
            ["Alice", "Mike", ""],
            ["Bob", "Jim", "Bob Sponge"],
            ["Carol", "Bob", ""]]'>
</google-chart>

</body>
</html>`
@wesalvaro
Copy link
Member

This looks like a duplicate of #138 which would be fixed by a fix for #26.
I have a fix in #204 but it essentially changes everything, so I need a good reviewer (I also need to add some more tests). I believe that #204 is a much more Polymer-y version that has a bunch of needed changes/refactors. If you want to take a look, that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesalvaro @Hareesh-kumar-kuruba