Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom window constructor #125

Conversation

idanrozin
Copy link

So, related to issue #124 I have opened a PR for whomever is interested. hope it helps and someone will take it to review and merge :)

regarding the tests. I know it looks awful in the diff view but what I essentialy did is just to create another test suite which runs the same tests but with the new constructor edition. so i needed to extract the funcitons logic outside and use closure on some. but basically this is the structure:

before each (the only change here is the instantiation of StackdriverErrorReporter and window which is done inside the tests suites itself.
first suite -> same logic
second suite -> same logic just with new StackdriverErrorReporter(customWindow)

Thanks!

@google-cla
Copy link

google-cla bot commented Dec 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@steren
Copy link
Collaborator

steren commented Jan 4, 2023

Thanks for the PR @idanrozin, any reason why you closed it? Signign the CLA is standard to contribute to Google-own code.

@steren
Copy link
Collaborator

steren commented Jan 4, 2023

Ah sorry I see #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants