Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.* resource attributes to metrics labels #459

Open
aabmass opened this issue Nov 30, 2022 · 5 comments
Open

Add service.* resource attributes to metrics labels #459

aabmass opened this issue Nov 30, 2022 · 5 comments
Assignees
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request priority: p2

Comments

@aabmass
Copy link
Contributor

aabmass commented Nov 30, 2022

This prevents writing duplicate timeseries from different processes when they correspond to the same monitored resource. For example, three processes on the same gce_instance VM need a label to distinguish them.

We already do this in the collector exporter as we have specced out.

@aabmass
Copy link
Contributor Author

aabmass commented Jan 4, 2023

Need to work on this before the stable metrics exporter release.

@Le-G
Copy link

Le-G commented Jan 18, 2023

While this is implemented, is there a way to include those service resource labels (or any other unique id) in the metrics labels other than manually adding them to the metric labels ?
Not having this causes duplicates when sending metrics concurrently.

@aabmass
Copy link
Contributor Author

aabmass commented Jan 18, 2023

You'd have to add them manually for now unfortunately.

@aabmass
Copy link
Contributor Author

aabmass commented Jan 18, 2023

We'd probably want to implement it as a configurable option with a default, similar to how the Golang exporter does it https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/3e654c04a79bd43915e5e47f71213e868799ff92/exporter/metric/option.go#L46-L49

@aabmass aabmass added the enhancement accepted An actionable enhancement for which PRs will be accepted label Jul 17, 2023
@aabmass
Copy link
Contributor Author

aabmass commented Jul 17, 2023

Leaving this up for grabs as I still don't have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request priority: p2
Projects
None yet
Development

No branches or pull requests

2 participants