Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Batch Limit for Stackdriver Exporter #575

Closed
marvinkite opened this issue Jan 19, 2023 · 9 comments
Closed

Add Batch Limit for Stackdriver Exporter #575

marvinkite opened this issue Jan 19, 2023 · 9 comments
Assignees
Labels
bug Something isn't working priority: p2

Comments

@marvinkite
Copy link
Contributor

On high-velocity metrics, you get:

InvalidArgument - Field timeSeries had an invalid value: A maximum of 200 TimeSeries can be written in a single request.

Apparently Stackdriver backend has the limit that each request cannot batch more than 200 time series so exporter needs to do some processing.

I have this issue with f0e0c76 commit

github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.34.3-0.20230106160205-f0e0c76a62e3

See GoogleCloudPlatform/opentelemetry-operations-js/issues/87

@dashpole dashpole added bug Something isn't working priority: p2 labels Jan 19, 2023
@dashpole
Copy link
Contributor

Thanks for reporting this! This is definitely something we need to implement. It exists on the googlecloud collector exporter for metrics, but not on the SDK exporter right now.

@khong-sc
Copy link

Would it be possible to get this ticket prioritized? I currently can't use the latest version of the exporter in production because it will constantly throw the maximum time series error. Thanks!

@damemi damemi self-assigned this Feb 27, 2023
@damemi
Copy link
Contributor

damemi commented Feb 27, 2023

@dashpole I can work on this if you'd like

@dashpole
Copy link
Contributor

@damemi go for it.

@gagata
Copy link

gagata commented Mar 15, 2023

hi @damemi was there any progress on this?

@knightpp
Copy link
Contributor

A naive implementation could be main...knightpp:opentelemetry-operations-go:issue-575.

@zchee
Copy link
Contributor

zchee commented Mar 20, 2023

@knightpp cc: @dashpole
Could you create new PR based above change? My company team has same issue.
If can't send PR with any reason, I'll create instead based by your changes with adding Co-Author mark.

@knightpp
Copy link
Contributor

@zchee I've created a PR. I hope the PR is good enough to be merged. Thanks.

@damemi
Copy link
Contributor

damemi commented Mar 21, 2023

Fixed by #617, thanks @knightpp for contributing that!

@damemi damemi closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: p2
Projects
None yet
Development

No branches or pull requests

7 participants