Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup vcpkg manifest for pubsub + OTel #349

Open
dbolduc opened this issue Jun 3, 2024 · 0 comments
Open

Cleanup vcpkg manifest for pubsub + OTel #349

dbolduc opened this issue Jun 3, 2024 · 0 comments
Labels
external This issue is blocked on a bug with the actual product.

Comments

@dbolduc
Copy link
Member

dbolduc commented Jun 3, 2024

Our opentelemetry feature should depend on monitoring in our vcpkg port. We should not have to manually depend on it in this example's manifest file.

cpp-samples/pubsub-open-telemetry/vcpkg.json

Line 12 in f214349

"monitoring"

We can remove the workaround when we

  • update our vcpkg port
  • update the vcpkg version used in our CI
@dbolduc dbolduc added the external This issue is blocked on a bug with the actual product. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external This issue is blocked on a bug with the actual product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbolduc