Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context canceled errors should not invalidate the cache #831

Closed
enocom opened this issue Jul 3, 2024 · 1 comment
Closed

Context canceled errors should not invalidate the cache #831

enocom opened this issue Jul 3, 2024 · 1 comment
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Jul 3, 2024

When a caller cancels the context before the Dial, EngineVersion, or Warmup methods can complete, we currently invalidate the cache. Instead, we should allow the cache to remain intact on context canceled errors.
@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 3, 2024
@enocom enocom mentioned this issue Jul 3, 2024
Closed
@enocom
Copy link
Member Author

enocom commented Jul 4, 2024

Closing in favor of GoogleCloudPlatform/cloud-sql-proxy#2260.

@enocom enocom closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enocom @jackwotherspoon