This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 148
Setup folder structure to store artifact configurations #1037
Labels
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: process
A process-related concern. May include testing, release, or the like.
Milestone
Comments
minherz
added
the
type: process
A process-related concern. May include testing, release, or the like.
label
Jun 9, 2023
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 9, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
minherz
added a commit
that referenced
this issue
Jun 10, 2023
Change layout of configurations and configuration schemas (see #1037) Add schema validation to configurations-ci job.
Closed
Commenting since this is in our team's out-of-SLO bucket:
|
minherz
added
the
priority: p3
Desirable enhancement or fix. May not be included in next release.
label
Dec 4, 2023
@NimJay I depreoritized it to p3. However, I prefer to keep all relevant issues opened until we decide on the roadmap of the project. Once it is decided I will go to update the milestones and change the issues accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: process
A process-related concern. May include testing, release, or the like.
Description
All Configurations are stored under
/configurations
folder at the root of the repo. Each Configuration is stored in a dedicated folder. The name of the folder is used as ID of the configuration. The name is validated by regex^[a-zA-Z_][a-z-A-Z0-9_\-]+$
(letters, numbers, underscore and dash, starting with a letter or underscore with the length greater than 1).Inside each Configuration the parameters are stored in multiple files per artifact functionality:
Additionally, the folder will has a recipe subfolder
/configurations/{ID}/recipes
to store o11y recipes (see #1028)Schemas for these YAML files will be stored in the
/provisioning/schemas/configuration
folder.Describe alternatives you've considered
The following options were considered:
pros simple to transfer and host
cons hard to manage or even understand because the file will be too big
pros flexible storage options
pros allows artifact parameters across multiple files (e.g. two files to store service SLOs)
pros allows reuse configurations
cons hard to host and transfer; increases chances to cause unexpected problems when modifying a file referenced in more than one Configuration
cons hard to manage or even understand because the files can be distributed and parameters can conflict
Additional context
It is a sub-issue for #1026.
The text was updated successfully, but these errors were encountered: