Update Linux kernel version in kernel compile benchmark #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On static Ubuntu 18.04 vms with gcc version 7.5.0, the kernel_compile_benchmark fails with: STDERR: arch/x86/Makefile:133: stack-protector enabled but compiler support broken Makefile:668: Cannot use CONFIG_CC_STACKPROTECTOR_REGULAR: -fstack-protector not supported by compiler The mainline linux commit that seems to resolve the issue is [82031ea29e454b574bc6f49a33683a693ca5d907](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82031ea29e454b574bc6f49a33683a693ca5d907). The attached patch updates the kernel version to the closest one that builds without issues. Probably needs some more testing with other setups.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
bvliu
requested changes
Nov 20, 2020
| LINUX_VERSION = '4.4.35' | ||
| URL = 'https://www.kernel.org/pub/linux/kernel/v4.x/linux-%s.tar.gz' %(LINUX_VERSION) | ||
| TARBALL = 'linux-%s.tar.gz' %(LINUX_VERSION) | ||
| UNTAR_DIR = 'linux-%s' %(LINUX_VERSION) |
There was a problem hiding this comment.
Prefer use of f-strings: https://www.python.org/dev/peps/pep-0498/
LINUX_VERSION = '4.4.35'
URL = f'https://www.kernel.org/pub/linux/kernel/v4.x/linux-{LINUX_VERSION}.tar.gz'
There was a problem hiding this comment.
No, I have only tested this on static VMs as part of the evaluation of a single local node.
I have pushed the conversion to f-strings on top of my branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am testing pkb benchmarks on static vms.
On Ubuntu 18.04 setups with gcc version 7.5.0, the kernel_compile_benchmark fails with:
STDERR: arch/x86/Makefile:133: stack-protector enabled but compiler support broken
Makefile:668: Cannot use CONFIG_CC_STACKPROTECTOR_REGULAR: -fstack-protector not supported by compiler
The kernel version used for this benchmark is 4.4.25. Looking through versions and diffs, the 4.4.35 version is the closest that builds without issues.
The commits that seem to resolve the issue are:
mainline 82031ea29e454b574bc6f49a33683a693ca5d907
stable 3a868dde1824d4eca277df490d2be99355320095
Probably more testing is needed with other setups.
Thanks,
Emmanouil Maroudas