Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP persistent disk ID to metadata of pkb #5237

Open
jellyfishcake opened this issue Oct 4, 2024 · 0 comments
Open

Add GCP persistent disk ID to metadata of pkb #5237

jellyfishcake opened this issue Oct 4, 2024 · 0 comments
Labels
good first issue This is a good issue for someone new to PKB

Comments

@jellyfishcake
Copy link
Contributor

For this task, we want to store the disk ID in the disk metadata.

TASK:

Add a method in CreatePDDiskStrategy https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/providers/gcp/gce_disk_strategies.py#L56C7-L56C27 called UpdateDiskIDs

In UpdateDiskIDs, iterate through self.remote_disk_groups, then iterate through each disk in the disk group using nested for loop.

for each disk, call self.Describe to get the description json, parse the disk id from the json and add it as a field to disk. i.e. disk.id = 12345

For this task, we will need to provision a disk as well. We can use fio benchmark:

command: ./pkb.py --benchmarks=fio --data_disk_size=10 --data_disk_type=pd-ssd

@jellyfishcake jellyfishcake added the good first issue This is a good issue for someone new to PKB label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This is a good issue for someone new to PKB
Projects
None yet
Development

No branches or pull requests

1 participant