Support per-catalog configuration for project and location for BigQueryCatalog #1434

BoqianShi · 2025-10-23T22:45:50Z

This PR enhances the BigQueryCatalog by adding support for specifying a project and location directly in the Spark configuration. This allows users to easily register and interact with BigQuery datasets from different projects and locations without having to override the global parentProjectId.

This makes it easier to work with datasets in different projects and regions. For example, you can now read from a public dataset in one project and write to a table in a specific location (e.g., "US") in your own project.

How to Use
Users can now configure a BigQuery catalog with a specific project and location like this:

spark.conf.set("spark.sql.catalog.my_catalog", "com.google.cloud.spark.bigquery.BigQueryCatalog")
spark.conf.set("spark.sql.catalog.my_catalog.projectId", "bigquery-public-data")
spark.conf.set("spark.sql.catalog.my_catalog.location", "US")

BoqianShi · 2025-10-23T22:46:01Z

/gcbrun

gemini-code-assist · 2025-10-23T22:46:12Z

Summary of Changes

Hello @BoqianShi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the BigQueryCatalog by introducing support for per-catalog configuration of BigQuery project IDs and locations. This allows Spark users to define specific BigQuery projects and geographical regions for each registered catalog, providing greater flexibility when interacting with diverse BigQuery datasets. The change streamlines workflows that involve reading from public datasets in one project and writing to tables in a different project or region, eliminating the need to manage global overrides and simplifying complex data pipelines.

Highlights

Per-Catalog Project and Location Configuration: Users can now specify a dedicated BigQuery project ID and geographical location for each individual BigQueryCatalog registered in Spark. This allows for more granular control over data access and storage.
Enhanced BigQuery Client Integration: The underlying BigQuery client now prioritizes these per-catalog project and location settings for operations like dataset creation, falling back to global configurations if catalog-specific ones are not provided.
Improved Flexibility for Multi-Project/Region Workflows: This enhancement simplifies scenarios where users need to interact with BigQuery datasets residing in different projects or regions within a single Spark application, such as reading from public datasets and writing to private ones in a specific location.
Comprehensive Testing: New unit and integration tests have been added to validate the correct parsing, application, and functionality of these new per-catalog project and location configurations, ensuring robustness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

BoqianShi · 2025-10-23T22:47:21Z

/gcbrun

gemini-code-assist

Code Review

This pull request adds support for per-catalog configuration of project and location for the BigQueryCatalog. The changes correctly plumb the new configuration options through to the BigQueryClient used by the catalog for namespace-level operations. However, there is a significant issue where these catalog-level configurations are not propagated to the Table objects returned by loadTable and createTable. This means that table-level operations, such as reads and writes, will not use the specified project or location from the catalog configuration, making the feature incomplete. I've added a detailed comment with a suggested fix for this issue.

...v2/spark-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/BigQueryCatalog.java

…alog and table

BoqianShi · 2025-10-24T23:48:15Z

/gcbrun

BoqianShi · 2025-10-25T06:34:58Z

/gcbrun

…alog and table

BoqianShi · 2025-10-27T19:57:16Z

/gcbrun

davidrabinowitz · 2025-10-27T20:16:09Z

...onnector-common/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClient.java


  public void createDataset(DatasetId datasetId, Map<String, String> metadata) {
    DatasetInfo.Builder datasetInfo = DatasetInfo.newBuilder(datasetId);
+    Optional.ofNullable(bigQuery.getOptions().getLocation()).ifPresent(datasetInfo::setLocation);


Please add comment for this line explaining why it is there

In a non-catalog scenario, both BigQueryOptions.quotaProjectId and BigQueryOptions.projectId will be set to the parent projectId, as before.

davidrabinowitz · 2025-10-27T20:19:22Z

...uery-connector-common/src/main/java/com/google/cloud/spark/bigquery/SparkBigQueryConfig.java

    config.parentProjectId =
        getAnyOption(globalOptions, options, "parentProject").or(defaultBilledProject());
+    config.catalogProjectId = getOption(options, "projectId");
+    config.catalogLocation = getOption(options, "location");


Is the parameter location or bigquery_location?

davidrabinowitz · 2025-10-27T20:20:31Z

...uery-connector-common/src/main/java/com/google/cloud/spark/bigquery/SparkBigQueryConfig.java

  com.google.common.base.Optional<String> temporaryGcsBucket = empty();
  com.google.common.base.Optional<String> persistentGcsBucket = empty();
  com.google.common.base.Optional<String> persistentGcsPath = empty();
+  com.google.common.base.Optional<String> catalogProjectId = empty();


add comment why do we need a separate set of properties

davidrabinowitz · 2025-10-27T20:21:49Z

...or-common/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClientModule.java

            .setRetrySettings(config.getBigQueryClientRetrySettings())
            .setUniverseDomain(bigQueryCredentialsSupplier.getUniverseDomain());

+    // Determine the project for data location (the catalog's project, if specified)


What happens if this is used in non-catalog scenario?

BoqianShi · 2025-10-28T16:46:38Z

/gcbrun

BoqianShi · 2025-11-03T10:38:06Z

/gcbrun

BoqianShi · 2025-11-03T10:43:52Z

/gcbrun

BoqianShi · 2025-11-04T22:56:49Z

/gcbrun

BoqianShi · 2025-11-07T02:31:26Z

/gcbrun

BoqianShi · 2025-11-07T02:40:00Z

/gcbrun

BoqianShi · 2025-11-07T03:27:31Z

/gcbrun

BoqianShi · 2025-11-07T05:46:18Z

/gcbrun

BoqianShi requested a review from davidrabinowitz October 23, 2025 22:45

Support per-catalog configuration for project and location

5fdf9ac

BoqianShi force-pushed the catalog-config branch from 2f415cf to 5fdf9ac Compare October 23, 2025 22:47

gemini-code-assist bot reviewed Oct 23, 2025

View reviewed changes

...v2/spark-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/BigQueryCatalog.java Outdated Show resolved Hide resolved

Change config name to support reading from both different project cat…

fe2c655

…alog and table

BoqianShi added 2 commits October 27, 2025 12:56

Change config name to support reading from both different project cat…

fb44842

…alog and table

Add default quotaProject

cb3ce19

davidrabinowitz requested changes Oct 27, 2025

View reviewed changes

Revert quota project setting

79f2585

Cloud build test only

f56cad8

BoqianShi force-pushed the catalog-config branch from 5132d73 to f56cad8 Compare November 3, 2025 10:43

Rename option location to bigquery_location

4ce3667

BoqianShi force-pushed the catalog-config branch from 8f6dcee to 4c90a8f Compare November 7, 2025 02:39

BoqianShi force-pushed the catalog-config branch 2 times, most recently from 305ed1f to 5ec52be Compare November 7, 2025 03:27

BoqianShi force-pushed the catalog-config branch from 5ec52be to 98dff65 Compare November 7, 2025 05:43

Add more logging for cloud run debugging

2a3b78a

BoqianShi force-pushed the catalog-config branch from 98dff65 to 2a3b78a Compare November 7, 2025 05:45

Support per-catalog configuration for project and location for BigQueryCatalog #1434

Are you sure you want to change the base?

Support per-catalog configuration for project and location for BigQueryCatalog #1434

Uh oh!

Conversation

BoqianShi commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BoqianShi commented Oct 23, 2025

Uh oh!

gemini-code-assist bot commented Oct 23, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

BoqianShi commented Oct 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

BoqianShi commented Oct 24, 2025

Uh oh!

BoqianShi commented Oct 25, 2025

Uh oh!

BoqianShi commented Oct 27, 2025

Uh oh!

davidrabinowitz Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

BoqianShi Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

davidrabinowitz Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

davidrabinowitz Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

davidrabinowitz Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

BoqianShi commented Oct 28, 2025

Uh oh!

BoqianShi commented Nov 3, 2025

Uh oh!

BoqianShi commented Nov 3, 2025

Uh oh!

BoqianShi commented Nov 4, 2025

Uh oh!

BoqianShi commented Nov 7, 2025

Uh oh!

BoqianShi commented Nov 7, 2025

Uh oh!

BoqianShi commented Nov 7, 2025

Uh oh!

BoqianShi commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BoqianShi commented Oct 23, 2025 •

edited

Loading