Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bombs above the scroll bar #499

Open
dtudury opened this issue Aug 16, 2019 · 0 comments
Open

bombs above the scroll bar #499

dtudury opened this issue Aug 16, 2019 · 0 comments

Comments

@dtudury
Copy link

dtudury commented Aug 16, 2019

Debug info
Version: 1.0.9
Motion: true
Supports WebGL: true
Feature Phone: no
Standalone Mode: no
Screen Width: 749px
Screen Height: 821px
DPR: 1
Device Memory: 8
Concurrency: 4
UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Describe the bug
in the lose state, on maps with scroll bars, the bombs appear above the scroll bar

To Reproduce
Steps to reproduce the behavior:

  1. lose
  2. resize until you get scroll bars
  3. scroll a bomb to the right edge
  4. see the bomb go over the scroll bar

Expected behavior
the bombs should be under the scroll bar.

switching the order of the main canvas and the div that wraps the table seems to fix it (I tried to fix it in a fork but it wasn't as simple to add as I'd anticipated EDIT: PR below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant