Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend AddPreloadScript with ContextId parameter #1353

Open
3 of 4 tasks
sadym-chromium opened this issue Sep 28, 2023 · 1 comment
Open
3 of 4 tasks

Extend AddPreloadScript with ContextId parameter #1353

sadym-chromium opened this issue Sep 28, 2023 · 1 comment
Assignees
@Lightning00Blade

Comments

@sadym-chromium
Copy link
Collaborator

sadym-chromium commented Sep 28, 2023 •
edited by Lightning00Blade
Loading

The parameter was added in w3c/webdriver-bidi#517 needs to be implemented, so it can be used in Puppeteer.

WPT tests will be added in web-platform-tests/wpt#41932.

  • Invalid inputs
  • PreloadScripts are ran supplied Contexts
  • PreloadScripts are not ran for newly created BrowsingContexts creation (via browsingContext.create)
  • PreloadScripts are ran for Workers, fenced frames (Connected Contexts but separate CDP targets)
@sadym-chromium sadym-chromium mentioned this issue Sep 28, 2023
Closed
20 tasks
@thiagowfx
Copy link
Contributor

cc @Lightning00Blade

@thiagowfx thiagowfx mentioned this issue Oct 24, 2023
Merged
Lightning00Blade added a commit that referenced this issue Oct 25, 2023
@Lightning00Blade
chore: parse addPreloadScript params (#1471)
3122e93 
WPT should cover this case
web-platform-tests/wpt#41932

Tracked at #1353
@Lightning00Blade Lightning00Blade mentioned this issue Oct 25, 2023
Merged
Lightning00Blade added a commit that referenced this issue Oct 25, 2023
@Lightning00Blade
feat: addPreloadScript respects new contexts (#1478)
b0e55fa 
We should be OK using the global approach due to
https://w3c.github.io/webdriver-bidi/#command-script-addPreloadScript
Step 4 - making sure that the Context exits, if we don't already have it
we in our storage.
Adding the note because on there was discussion around ID and sharing
them between Multiple BiDi sessions.

From Alex: The above is only true if we are adding the scripts to same
origin iframes. This will not work for example for workers, cross-origin
iframes and a like that create a new target, and per spec preload
scripts should affect them as well.

Tracked at #1353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lightning00Blade Lightning00Blade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thiagowfx @Lightning00Blade @sadym-chromium