Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better rotate and delete #613

Open
argyleink opened this issue Nov 9, 2023 · 8 comments · May be fixed by #657
Open

Better rotate and delete #613

argyleink opened this issue Nov 9, 2023 · 8 comments · May be fixed by #657

Comments

@argyleink
Copy link
Member

https://github.com/daybrush/moveable

shows a great interaction for removing and rotating elements

@hchiam
Copy link
Contributor

hchiam commented Feb 19, 2025

removing elements can already be done by selecting and hitting the delete key, unless you were thinking of deleting multiple elements simultaneously at the time of writing this issue? (which i tested doesn't currently work in VisBug 0.4.6 for Firefox but does work in VisBug 0.4.10 for Chrome)

and were you thinking of using Rotatable under the Position Tool?

@argyleink
Copy link
Member Author

Image

^ it's got the rotation handle there and the delete button

could be part of the Position Tool yep, and the delete button could just always be there.

@hchiam
Copy link
Contributor

hchiam commented Feb 19, 2025

nice! i plan to work on this hopefully sometime next week

@hchiam
Copy link
Contributor

hchiam commented Feb 27, 2025

minimal demo: https://codepen.io/hchiam/pen/xbxReqy

i can't seem to find a built-in delete button for moveable rotatable, so i'm assuming you got that working with some custom code with the ables option? https://daybrush.com/moveable/release/latest/doc/Moveable.html#.DefaultOptions-ables

@argyleink
Copy link
Member Author

i found it via their demo page https://daybrush.com/moveable/, not sure what settings are needed

@hchiam
Copy link
Contributor

hchiam commented Feb 27, 2025

for reference / note to self as i try to figure this out for vanilla js: daybrush/moveable#246 (comment)

@hchiam
Copy link
Contributor

hchiam commented Feb 27, 2025

@hchiam
Copy link
Contributor

hchiam commented Feb 28, 2025

i'm almost ready to make a PR, just need to figure out how to ignore selecting the delete button (the code that adds visbug-labels) and some other final tweaks (UPDATE: seems like editing notList in strings.js doesn't do anything, but isOffBounds in common.js does)

@hchiam hchiam linked a pull request Feb 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants