Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: increase default protocol timeout to 10s #6505

Merged
merged 1 commit into from
Nov 8, 2018
Merged

core: increase default protocol timeout to 10s #6505

merged 1 commit into from
Nov 8, 2018

Conversation

connorjclark
Copy link
Collaborator

Fixes #6475.

@brendankenny brendankenny changed the title increase generic protocol timeout to 10s core: increase default protocol timeout to 10s Nov 8, 2018
brendankenny
brendankenny approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@brendankenny brendankenny merged commit 9600b50 into master Nov 8, 2018
@brendankenny brendankenny deleted the Hoten-patch-1 branch November 8, 2018 00:49
@connorjclark
Copy link
Collaborator Author

@brendankenny @patrickhulce I modified the wrong value here ...

@connorjclark
Copy link
Collaborator Author

#6531 got it right :)

@patrickhulce
Copy link
Collaborator

ha, woah can't believe we all missed that 😆

@brendankenny
Copy link
Member

😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @patrickhulce @brendankenny